Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

crash when set line_height=0 #2247

Closed
zenithyr opened this issue Jul 12, 2022 · 2 comments
Closed

crash when set line_height=0 #2247

zenithyr opened this issue Jul 12, 2022 · 2 comments
Labels
bug Something isn't working fixed-in-nightly This is (or is assumed to be) fixed in the nightly builds.

Comments

@zenithyr
Copy link

What Operating System(s) are you seeing this problem on?

macOS

WezTerm version

20220624-141144-bd1b7c5d

Did you try the latest nightly build to see if the issue is better (or worse!) than your current version?

Yes, and I updated the version box above to show the version of the nightly that I tried

Describe the bug

In the config, if we set line_height=0 and save, the application crashes right away and won't start.

To Reproduce

No response

Configuration

local wezterm=require 'wezterm';

return {
  font_size = 14.0,
  line_height = 0
}

Expected Behavior

When restart, show error message that line_height must be greater than 0.

Logs

No response

Anything else?

No response

@zenithyr zenithyr added the bug Something isn't working label Jul 12, 2022
wez added a commit that referenced this issue Jul 12, 2022
It's now possible to specify a validation function for config
items.

Use that to validate line_height:

```
; ./target/debug/wezterm --config line_height=-1
08:41:10.576  ERROR  wezterm > Error converting lua value from overrides to Config struct: Error processing Config::line_height: Illegal value -1 for line_height; it must be positive and greater than zero!; terminating
```

refs: #2247
@wez wez added the fixed-in-nightly This is (or is assumed to be) fixed in the nightly builds. label Jul 12, 2022
@wez
Copy link
Owner

wez commented Jul 12, 2022

This should be fixed now in main.

It typically takes about an hour before fixes are available as nightly builds for all platforms. Linux builds are the fastest to build and are often available within about 20 minutes. Windows and macOS builds take a bit longer.

Please take a few moments to try out the fix and let me know how that works out. You can find the nightly downloads for your system in the wezterm installation docs.

If you prefer to use packages provided by your distribution or package manager of choice and don't want to replace that with a nightly download, keep in mind that you can download portable packages (eg: a .dmg file on macOS, a .zip file on Windows and an .AppImage file on Linux) that can be run without permanently installing or replacing an existing package, and can then simply be deleted once you no longer need them.

If you are eager and can build from source then you may be able to try this out more quickly.

@github-actions
Copy link
Contributor

github-actions bot commented Feb 3, 2023

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working fixed-in-nightly This is (or is assumed to be) fixed in the nightly builds.
Projects
None yet
Development

No branches or pull requests

2 participants