-
-
Notifications
You must be signed in to change notification settings - Fork 801
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mux doesn't recognize window size in tiling environments #2351
Comments
Related issues: |
Since the initial attach is async, we'd create the window at the default/initial size and then never reconcile the size of the remote tabs once they'd attached. This commit introduces an event that allows the gui window to do that. The action that it takes is to take the max width and height between its current size and the size of a newly added tab and resizes to that new size, if it changed. refs: #2133 refs: #2351
The behavior has been improved in |
Now compiled from ef532fc, but couldn't see anything different. Checking the change, it feels like adding a new tab should do it, but sadly it didn't. Here is an example split inside new tab: Tried getting debug log but couldn't see anything shiny in it, I could provide some trace if it could help. |
Hate to just give a plain +1, but if there's any kind of log or data collection I could offer, I have exactly the same bug. Wezterm 20221119-145034-49b9839f. Resize behavior is perfect if I use |
Would you mind trying the latest nightly build and let me know whether this is resolved? |
Sadly it is same. (from alacritty): running
After it starts, running
Then opens a window like this, unless I resize it confines terminal in lesser area: |
It's possible that 8dd365d may help here |
Thanks. It looks like it helped 🚀
|
8f74e1c fixes some cache invalidation issues around resizing, not sure that it will help here, but I thought it was worth a mention. |
Thanks for the reminder. I wasn't using the nightly for a while, and already testing the flake from #4843 (which doesn't even cover the commit you mentioned, forked over 12a6b8d). |
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
What Operating System(s) are you seeing this problem on?
Linux X11
Which Wayland compositor or X11 Window manager(s) are you using?
awesomewm 4.3
WezTerm version
Compiled from commit 119c2f1
Did you try the latest nightly build to see if the issue is better (or worse!) than your current version?
No, and I'll explain why below
Describe the bug
Tried to switch to mux, but apparently it's not correctly evaluating window size on startup.
This is not the case if I start a normal terminal with
wezterm start --class mainqterm
command. It happens when I runwezterm connect default --class mainqterm
command.I tried to do some hacks but couldn't change the main behavior: It starts like this and only corrects itself once I resize the window, or reload the configuration.
To Reproduce
I guess you'd need an environment with window rules defined & enforce maximizing of the Wezterm windows on start
Configuration
Expected Behavior
Similar behavior for the non-mux window, initial row/col count matching the initial window size.
Logs
Anything else?
Relevant discussion item: #2311 (comment)
The text was updated successfully, but these errors were encountered: