-
-
Notifications
You must be signed in to change notification settings - Fork 801
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[wezterm-ssh] libssh
backend hangs and ssh2
backend fails with success = false for cmd.exe /C echo %OS%
#2456
Labels
bug
Something isn't working
Comments
@wez I've written a standalone test that fails for me reliably without the distant codebase. Check out https://github.com/chipsenkbeil/wezterm-ssh-test If I set BACKEND to ssh2, it outputs:
If I set BACKEND to libssh, it hangs like this:
|
@wez couple of learnings
|
wez
added a commit
that referenced
this issue
Aug 30, 2022
Inspecting the wezterm process with `lsof -p`, before and after closing a pane with `CloseCurrentPane`, the same number of unix domain sockets are open, which is bad. This commit tries a bit harder to clean things up: if we got a process exit condition we now remember that we had it, and, while processing the IO for that channel, if we have no data for stdout or stderr (respectively) and the channel exited, we close our end of the socketpair to encourage EOF to be detected on the other end. This is sufficient to restore the number of open files to the same number wezterm had opened prior to opening that pane. @chipsenkbeil: this might possibly be a factor in the issue you reported, but I haven't had time to really dig into that yet! refs: #2466 refs: #2456
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
What Operating System(s) are you seeing this problem on?
macOS (12.4 on MacBook Air (M1, 2020))
Remote machine is Windows 11 Home version 21H2
Which Wayland compositor or X11 Window manager(s) are you using?
No response
WezTerm version
wezterm-ssh 0.4.0
Did you try the latest nightly build to see if the issue is better (or worse!) than your current version?
No, and I'll explain why below
Describe the bug
When attempting to run
wezterm_ssh::Session::exec
, I'm seeing odd behavior when connected from a Unix host (MacOS) to a Windows remote machine (Windows 11).For the backend
ssh2
, the command exits withsuccess
set to false and no stdout or stderr ever received. The log withwezterm_ssh_verbose
set totrue
is this:For backend
libssh
, the exec appears to hang for me (could be a user error) and the log is this:To Reproduce
No response
Configuration
no config
Expected Behavior
No response
Logs
No response
Anything else?
No response
The text was updated successfully, but these errors were encountered: