Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rendering broken with split panes after zoom unzoom #3111

Closed
snaggen opened this issue Feb 14, 2023 · 5 comments
Closed

Rendering broken with split panes after zoom unzoom #3111

snaggen opened this issue Feb 14, 2023 · 5 comments
Labels
bug Something isn't working fixed-in-nightly This is (or is assumed to be) fixed in the nightly builds.

Comments

@snaggen
Copy link

snaggen commented Feb 14, 2023

What Operating System(s) are you seeing this problem on?

Linux Wayland

Which Wayland compositor or X11 Window manager(s) are you using?

Mutter Wayland

WezTerm version

20230212-103106-a5c2b1f3

Did you try the latest nightly build to see if the issue is better (or worse!) than your current version?

Yes, and I updated the version box above to show the version of the nightly that I tried

Describe the bug

I can now, with a nightly I just installed break rendering, so the text are rendered over the split pane width.

  1. Split a terminal into 2 panes.
  2. zoom the left pane to fill the whole window.
  3. cat a file with long lines that fill the window width.
  4. unzoom back to the split view. Now the rendering is broken, so the lines are still rendered with full width.

Any resize event will fix the rendering issue.

On a upgraded Fedora 37 under wayland on a x86_64 machine.

To Reproduce

No response

Configuration

no config

Expected Behavior

No response

Logs

No response

Anything else?

No response

@snaggen snaggen added the bug Something isn't working label Feb 14, 2023
@kaddkaka
Copy link

kaddkaka commented Feb 16, 2023

It's exactly commit cc15f97 that causes this bug to appear. (From #3068)

Is it somewhat easy to write tests for this? I haven't acquainted myself with the codebase yet.

@wez
Copy link
Owner

wez commented Mar 19, 2023

This should be resolved now in main.

It typically takes about an hour before commits are available as nightly builds for all platforms. Linux builds are the fastest to build and are often available within about 20 minutes. Windows and macOS builds take a bit longer.

Please take a few moments to try out the fix and let me know how that works out. You can find the nightly downloads for your system in the wezterm installation docs.

If you prefer to use packages provided by your distribution or package manager of choice and don't want to replace that with a nightly download, keep in mind that you can download portable packages (eg: a .dmg file on macOS, a .zip file on Windows and an .AppImage file on Linux) that can be run without permanently installing or replacing an existing package, and can then simply be deleted once you no longer need them.

If you are eager and can build from source then you may be able to try this out more quickly.

@wez wez added the fixed-in-nightly This is (or is assumed to be) fixed in the nightly builds. label Mar 19, 2023
@kaddkaka
Copy link

Works for me 👍

@snaggen
Copy link
Author

snaggen commented Mar 20, 2023

I can confirm it works for me too!

@wez wez closed this as completed Mar 20, 2023
@github-actions
Copy link
Contributor

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working fixed-in-nightly This is (or is assumed to be) fixed in the nightly builds.
Projects
None yet
Development

No branches or pull requests

3 participants