Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rendering glitch when using hide_tab_bar_if_only_one_tab in full screen #3439

Closed
Drllap opened this issue Apr 3, 2023 · 4 comments
Closed
Labels
bug Something isn't working fixed-in-nightly This is (or is assumed to be) fixed in the nightly builds. Windows Issue applies to Microsoft Windows

Comments

@Drllap
Copy link

Drllap commented Apr 3, 2023

What Operating System(s) are you seeing this problem on?

Windows

Which Wayland compositor or X11 Window manager(s) are you using?

No response

WezTerm version

wezterm 20230326-111934-3666303c

Did you try the latest nightly build to see if the issue is better (or worse!) than your current version?

No, and I'll explain why below

Describe the bug

When using hide_tab_bar_if_only_one_tab and full-screen mode (wezterm.action.ToggleFullScreen) part of the terminal window becomes transparent when the tab bar hide/show triggers due to the number of tabs changing.

To Reproduce

  • I have hide_tab_bar_if_only_one_tab enabled.
  • Here I have one tab open in full-screen:
    image
  • Then I create another tab and the application goes out of full-screen mode (kind of but not really):
    image
  • The same thing happens if I have two tabs open and close one of them.
  • Going in and out of full-screen mode fixes it.

Configuration

config.hide_tab_bar_if_only_one_tab = true

Expected Behavior

No response

Logs

Debug Overlay
wezterm version: 20230326-111934-3666303c x86_64-pc-windows-msvc
Window Environment: Windows
OpenGL version: Intel(R) HD Graphics P630 4.5.0 - Build 26.20.100.7925
Enter lua statements or expressions and hit Enter.
Press ESC or CTRL-D to exit

Anything else?

No response

@Drllap
Copy link
Author

Drllap commented Apr 4, 2023

The same visual glitch happens every time a change my config while in full screen mode, so probably not directly related to the hide_tab_bar_if_only_one_tab option.

@wez wez added the Windows Issue applies to Microsoft Windows label Apr 6, 2023
@wez
Copy link
Owner

wez commented Apr 8, 2023

This should be resolved now in main.

It typically takes about an hour before commits are available as nightly builds for all platforms. Linux builds are the fastest to build and are often available within about 20 minutes. Windows and macOS builds take a bit longer.

Please take a few moments to try out the fix and let me know how that works out. You can find the nightly downloads for your system in the wezterm installation docs.

If you prefer to use packages provided by your distribution or package manager of choice and don't want to replace that with a nightly download, keep in mind that you can download portable packages (eg: a .dmg file on macOS, a .zip file on Windows and an .AppImage file on Linux) that can be run without permanently installing or replacing an existing package, and can then simply be deleted once you no longer need them.

If you are eager and can build from source then you may be able to try this out more quickly.

@Drllap
Copy link
Author

Drllap commented Apr 8, 2023

Can confirm, fixed on 20230408-112425-69ae8472

@Drllap Drllap closed this as completed Apr 8, 2023
@github-actions
Copy link
Contributor

github-actions bot commented May 9, 2023

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 9, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working fixed-in-nightly This is (or is assumed to be) fixed in the nightly builds. Windows Issue applies to Microsoft Windows
Projects
None yet
Development

No branches or pull requests

2 participants