Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Font rendering changed with latest version #4908

Closed
giann opened this issue Jan 30, 2024 · 6 comments
Closed

Font rendering changed with latest version #4908

giann opened this issue Jan 30, 2024 · 6 comments
Labels
bug Something isn't working fixed-in-nightly This is (or is assumed to be) fixed in the nightly builds.

Comments

@giann
Copy link

giann commented Jan 30, 2024

What Operating System(s) are you seeing this problem on?

macOS

Which Wayland compositor or X11 Window manager(s) are you using?

No response

WezTerm version

20240128-202157-1e552d76

Did you try the latest nightly build to see if the issue is better (or worse!) than your current version?

No, and I'll explain why below

Describe the bug

Font rendering suddenly got worse:

Before (20230712-072601-f4abf8fd):
Screenshot 2024-01-30 at 13 41 51

Now (20240128-202157-1e552d76):
Screenshot 2024-01-30 at 13 40 32

I tried playing with some font related config with no success.

To Reproduce

No response

Configuration

local wezterm = require("wezterm")

local function schemeForAppearance(appearance)
        if appearance:find("Dark") then
                return "ayu-dark"
        else
                return "ayu-light"
        end
end

return {
        font = wezterm.font("Iosevka Term SS04"),
        color_scheme = schemeForAppearance(wezterm.gui.get_appearance()),
        enable_tab_bar = true,
        hide_tab_bar_if_only_one_tab = true,
        initial_cols = 120,
        initial_rows = 39,
        audible_bell = "Disabled",
        line_height = 1.02,
        automatically_reload_config = true,
        enable_tab_bar = false,
}

Expected Behavior

No response

Logs

No response

Anything else?

No response

@giann giann added the bug Something isn't working label Jan 30, 2024
@lukasbindreiter
Copy link

I encountered the same issue - with the latest version the font seems very blurry and not sharp.

I think it is somehow related to Monitor DPI scaling, because for me it only was like this on my external monitor, for the built-in Mac display it looked the same as before.

Downgrading to the latest 2023 version resolved the issue again.

I tried setting config.dpi = 144, with that setting it looked sharp again, but on the built-in display it is way too large then so that's also not really an option. 😅

@hyperpuncher
Copy link
Contributor

hyperpuncher commented Jan 30, 2024

You can set freetype_load_flags = "DEFAULT" to get back previous font sharpness. It's mostly needed on low PPI displays (e.g., <100). But this only works in the nightly build.

wez added a commit that referenced this issue Jan 31, 2024
Only use it when we think the dpi is high, otherwise use the
default freetype parameters.

refs: #4908
refs: #4902
@wez
Copy link
Owner

wez commented Jan 31, 2024

The default behavior for freetype_load_flags in nightly builds (when they pick up 21af10e) is to use NO_HINTING when the dpi is >= 100, otherwise DEFAULT

@ericuni
Copy link

ericuni commented Feb 1, 2024

I have the same issue too.
It can not display Chinese rightly.
image

environment

Debug Overlay
wezterm version: 20240128-202157-1e552d76 x86_64-apple-darwin
Window Environment: macOS 13.4 (22F66)
OpenGL: AMD Radeon Pro 555X OpenGL Engine 4.1 ATI-4.12.7

@wez
Copy link
Owner

wez commented Feb 2, 2024

@ericuni please file a separate issue

@wez wez added the fixed-in-nightly This is (or is assumed to be) fixed in the nightly builds. label Feb 2, 2024
@wez wez closed this as completed Feb 3, 2024
Copy link
Contributor

github-actions bot commented Mar 5, 2024

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 5, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working fixed-in-nightly This is (or is assumed to be) fixed in the nightly builds.
Projects
None yet
Development

No branches or pull requests

5 participants