Fix compile error by using i686-pc-windows-msvc #1998
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is to fix compile error by using i686-pc-windows-msvc related to my #1976.
wezterm/window/src/os/windows/window.rs
Line 52 in 3800710
I should have defined ISC_SHOWUICOMPOSITIONWINDOW in DWORD (u32) because LPARAM (isize) cannot accept 2147483648 (0x80000000) when pointer size is 32bit.
This fix is not important at all because wezterm does not support 32bit windows.
So, if you don't need the fix, please close the PR.