Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add get_pane_direction method #3011

Merged
merged 3 commits into from
Feb 17, 2023

Conversation

alfa07
Copy link
Contributor

@alfa07 alfa07 commented Jan 26, 2023

It is useful for implementing custom navigation in lua. For example jumping between windows.

See also #3006 the PR it is split from and issue #3007 describing idea in more detail.

@wez
Copy link
Owner

wez commented Jan 27, 2023

The CI failures were fixed by 36519f0 ; please rebase!

@alfa07 alfa07 force-pushed the maxim.sokolov/add-get-pane-direction branch from aca22fe to d9f666a Compare January 28, 2023 02:00
@alfa07
Copy link
Contributor Author

alfa07 commented Feb 1, 2023

@wez looks like CI is broken?

@wez
Copy link
Owner

wez commented Feb 1, 2023

44f31c9 may encourage the freebsd CI to run. The rest of the workflows run in GH actions and need to manually approved by me for PRs from first-time-contributors

@alfa07 alfa07 force-pushed the maxim.sokolov/add-get-pane-direction branch from d9f666a to 5523256 Compare February 1, 2023 17:23
@alfa07
Copy link
Contributor Author

alfa07 commented Feb 1, 2023

freebsd fails again with

error: failed to run custom build command for `wayland-sys v0.29.5`

@jbeich
Copy link

jbeich commented Feb 2, 2023

wayland-sys failed due to missing dependencies: pkgconf + wayland. Caused by the following:

env PATH=$HOME/.cargo/bin:$PATH bash get-deps
Updating FreeBSD repository catalogue...
FreeBSD repository is up to date.
All repositories are up to date.
pkg: No packages available to install matching 'mesa-devel' have been found in the repositories

mesa-devel failed to build after GitHub hiccup (checksum mismatch as gzip compression ratio changed) but will re-appear in a few days (the next build starts on Saturday at 01:00 UTC and may take ~2 days). Also, mesa-devel shouldn't be used by CI as it doesn't provide any headers in order to co-exist with mesa-dri.

@alfa07
Copy link
Contributor Author

alfa07 commented Feb 2, 2023

hmm, does not look like macos failures are related to the PR either

@wez
Copy link
Owner

wez commented Feb 2, 2023

@jbeich oh, should https://github.com/wez/wezterm/blob/main/get-deps#L205 be switched out for something else? That script is used by both humans and CI, FWIW

@wez
Copy link
Owner

wez commented Feb 2, 2023

@alfa07 this is looking good, thanks! One thing left to do is add docs for this new method:

Create docs/config/lua/pane/get_pane_direction.md; you can base the new page off of docs/config/lua/pane/get_semantic_zones.md.

If you want to test the doc build, you need to install a couple of utilities:

cargo install --vers "^0.4" mdbook
cargo install mdbook-linkcheck
cargo install mdbook-mermaid
cargo install gelatyx --version "^0.2"

Then you can run the build like this:

./ci/build-docs.sh

and then open gh_pages/html/index.html in your browser.

@jbeich
Copy link

jbeich commented Feb 10, 2023

@wez, mesa-devel should be simply dropped but bsd_deps likely has more cruft. For example,

# List runtime dependencsies
$ pkg rquery %dn wezterm
xcb-util-image
xcb-util
libxkbcommon
libxcb
libX11
fontconfig
libssh2 # due to LIBSSH2_SYS_USE_PKG_CONFIG=1
wayland

# List build dependencies (also, omit docs and duplicates)
$ make -V BUILD_DEPENDS WITHOUT=DOCS -C/usr/ports/x11/wezterm |
  sed 'y/ /\n/' | sed '/\.pc/d; /^$/d; s,.*:[^/]*/,,'
rust
pkgconf

@alfa07
Copy link
Contributor Author

alfa07 commented Feb 17, 2023

@wez Do you think I need to change anything?

@wez wez merged commit 3b39aa5 into wez:main Feb 17, 2023
@wez
Copy link
Owner

wez commented Feb 17, 2023

Looks good, thank you!

wez added a commit that referenced this pull request Feb 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants