Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(config & window): use CGSSetWindowBackgroundBlurRadius to set ba… #3344

Closed
wants to merge 2 commits into from
Closed

feat(config & window): use CGSSetWindowBackgroundBlurRadius to set ba… #3344

wants to merge 2 commits into from

Conversation

Gkirito
Copy link
Contributor

@Gkirito Gkirito commented Mar 24, 2023

…ckground blur on macos

@Gkirito
Copy link
Contributor Author

Gkirito commented Mar 24, 2023

#3136
It is easier to set blur using CGSSetWindowBackgroundBlurRadius.

@Gkirito
Copy link
Contributor Author

Gkirito commented Mar 24, 2023

Hello, @wez Could you please review it again?

@Gkirito Gkirito mentioned this pull request Mar 24, 2023
Closed
@Gkirito
Copy link
Contributor Author

Gkirito commented Mar 24, 2023 •
edited
Loading

use this config file

local wezterm = require 'wezterm'
return {
  color_scheme = 'DoomOne',
  window_background_opacity = 0.8,

-- To disable the blur, set the value to `0`.
  macos_window_background_blur = 60,
  window_decorations = "TITLE|MACOS_FORCE_ENABLE_SHADOW"
}

wez
wez reviewed Mar 24, 2023
View reviewed changes
Copy link
Owner

@wez wez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, this looks much simpler!
I haven't tried to run this yet, but it looks clean.
I have one comment on naming

config/src/config.rs Outdated Show resolved Hide resolved
@Gkirito Gkirito requested a review from wez March 24, 2023 18:47
wez added a commit that referenced this pull request Mar 25, 2023
@wez
docs: changelog for #3344
b113cc9
@wez
Copy link
Owner

wez commented Mar 25, 2023

Thanks! rebased and pushed locally as 1b24ff1 and 63676c3

@wez wez closed this Mar 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wez wez Awaiting requested review from wez

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Gkirito @wez