CWOP passcode config and action #2
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Open
| @@ -368,8 +368,9 @@ int citizen_weather_send(struct config_type *config, char *aprsline) | |||
| } | |||
|
|
|||
| // The login/header line | |||
| sprintf(buffer,"user %s pass -1 vers open2300 %s\n", | |||
| config->citizen_weather_id, VERSION); | |||
| sprintf(buffer,"user %s pass %s1 vers open2300 %s\n", | |||
There was a problem hiding this comment.
should the 1 after the %s be there? It isn't in win2300.c below.
There was a problem hiding this comment.
Whoops! Will fix that and create another pull request.
For hams, CWOP needs a passcode other than the default -1 to accept data. * v2 fixes a typo introduced in linux2300.c * add a configuration setting CITIZEN_WEATHER_PASSCODE (passcode) * passcode defaults to -1 to maintain existing behavior * -1 may be replaced by passcode provided by CWOP server authority * passcode is read from conf file into config structure * apply passcode in TCP socket conversation with CWOP server
|
I've force updated master and fixed the issue there; will make another pull request |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For hams, CWOP needs a passcode other than the default -1 to accept
data.