-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Breaking enhancement] Swap out Pandas for Polars #96
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wfondrie
changed the title
[Breaking enhancement] Swap our Pandas for Polars
[Breaking enhancement] Swap out Pandas for Polars
Nov 3, 2023
Codecov Report
@@ Coverage Diff @@
## main #96 +/- ##
==========================================
- Coverage 85.36% 79.92% -5.45%
==========================================
Files 19 21 +2
Lines 1640 1315 -325
==========================================
- Hits 1400 1051 -349
- Misses 240 264 +24
📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a huge, in-progress PR swapping out the Pandas backend for Polars. The goal is to improve the speed and scalability of mokapot.
In addition to this huge change, this PR also:
LinearPsmDataset
in favor of justPsmDataset
, with an upcomingPeptideDataset
for DIA data. Similar API changes will also be made with the Confidence classes.Notably, this PR may also merge in work done by @sambenfredj.