-
Notifications
You must be signed in to change notification settings - Fork 140
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Compatible with a fish plugin manager #116
Comments
Hi @AoHiyuki. This is a great idea. Unfortunately I don't have a lot of experience using or developing fish plugins for these systems. Do you have any experience? If so, please feel free to do a PR on this! Otherwise it may be a little bit while I figure out how to make it work :) |
@AoHiyuki The main reason I object to splitting But for the fish version, it is not compatible with zsh or bash from the beginning (As you can see, it is a translation of the bash/zsh version, not a symbol link). Therefore, I am not opposed to splitting it. @cjappl is responsible for maintaining the fish version. You can freely discuss solutions with him. @AoHiyuki |
|
Sounds good. Thanks for the good work @wfxr and @AoHiyuki |
Only 1 minor issue @cjappl , but it doesn't affect anything badly. |
Any idea what the fix would be for this?
Thanks for catching it
…On Tue, Oct 13, 2020 at 10:56 AM AoHiyuki ***@***.***> wrote:
I just caught a minor issue. Didn't check things out thoroughly :(
forgit.plugin.fish appears in 2 places (even if it is just a symlink). So
when installed with Fisher it will be copied to both conf.d and functions
(the file in conf.d to ~/.config/fish/conf.d and the main file to
~/.config/fish/functions)
It works with no problems, but fish now will register a function named
forgit.plugin (that doesn't do anything) since the file is there in the
functions directory.
Only 1 minor issue @cjappl <https://github.com/cjappl> , but it doesn't
affect anything badly.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#116 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/ADMDXY46U5AQVUSHRZLQS5LSKSIFJANCNFSM4SJT6M7A>
.
|
@AoHiyuki I used symbol link to reuse the shorten url. fisher's mechanism for loading plugins seems a bit special. I wonder if it support the plugin placed in a subdirectory? Like this layout:
EDIT |
@AoHiyuki I replaced the link with actual file. You can update and test if it works fine. If everything is ok I will create a new shorten url for BTW now omf install https://github.com/wfxr/forgit @cjappl Would you like to submit a PR to this repo so that users can install forgit by using name instead of full url? |
@wfxr yeah it works fine. Thanks for the quick fix. Both Fisher and OMF utilize the conf.d directory, so we can already install The plugin doesn't work when installed with omf yet, as I mentioned. The file is sourced, but not everything will be "transported" to the shell.
|
Got it. @AoHiyuki |
@AoHiyuki Changed all variables which should be global to global. I think this is the rightway to solve the problem. |
I just installed OMF to test it and can confirm that it works. You can update README for both plugin managers now @wfxr . I didn't make the change earlier since I wasn't sure enough whether making them global could break things. |
Updated url from https://github.blog/changelog/2020-09-23-git-io-urls-no-longer-released-by-github-support/ |
Requested that we be added to the public repo: |
Will close when we are in there. |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
I'm just going to close this. We have done what we can and now we are waiting for an (extremely slow) external dependency. |
Check list
Environment info
Problem / Steps to reproduce
Hi. Thanks for a nice shell plugin.
I have some suggestions: maybe moving forgit.plugin.fish into a directory named conf.d so that it can be easily installed,updated and autoloaded with a plugin manager like fisher or oh my fish. And the file doesn't need to be executable.
The text was updated successfully, but these errors were encountered: