Fix path related bugs.

[wfxr]

Description

Fix some path related bugs. Add status indicator to forgit::diff command BTW.

Type of change

Please delete options that are not relevant.

• Bug fix
• (Minor) Feature : Add status indicator to forgit::diff command BTW.
• (Minor) Breaking change : Paths listed by forgit::diff will now use repo's root as the start point.

Shells this fix should effect:

• bash
• zsh
• fish

Shells this fix has been tested in:

• bash
• zsh
• fish

Test Configuration:

• OS: Arch Linux x86_64

Checklist:

• My code follows the style guidelines of this project
• I have performed a self-review of my own code
• I have commented my code, particularly in hard-to-understand areas
• I have made corresponding changes to the documentation

Related issue(s):

#39 : This pr will remove the dependency on realpath.

Please help sync the fish version. @cjappl

[cjappl]

Cool! I see this. I will get a commit in as soon as I can. I am on vacation so it may be a few days :)

[wfxr]

@cjappl No rush. Take your time :)

[cjappl]

Hi @wfxr, working on this now, but want to be 100% sure I'm understanding what this is before I put it in!

Can you explain what this sed command, and the sed command up top do? I'm not super well versed on sed

[wfxr]

Here regular expressions are used for capturing and replacing.

If you remove the escape character it will look a bit clearer:
sed 's/^(..[^[:space:]]*)[[:space:]]+(.*)$/[\1] \2/'.

What this line does is to capture the status indicator at the beginning of the line, surround it with square brackets, then append the full path. Completely explaining sed's regex rules is not easy. But you can test it to see how it works:

# go to `forgit`'s local repo
touch 'a          b   c'
echo 'hello world!' >> README.md

# buggy
git status --short | awk '{printf "[%10s]  ", $1; $1=""; print $0}'

# fixed
git status --short | sed 's/^\(..[^[:space:]]*\)[[:space:]]\+\(.*\)$/[\1]  \2/'