Pre-build the complete buffer of requests for pipelining #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There seems to be a limit of packages (framing overhead) and system calls which one can successfully send. This patch tries to optimize the number of packages send by pre-building the complete batch of pipelined requests into one big buffer. Also, the write handling is improved so that successful writing doesn't rely any more on the send buffer size (and network condition). Instead, the request buffer is written in chunks when the network allows it.
|
Thanks @jrudolph, I like it! Building one big buffer for the whole pipeline should be much more efficient than making many write() calls. I've implemented something similar to this, but separated into different commits to make merging between the various branches easier. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There seems to be a limit of packages (framing overhead) and system calls which one can successfully send. This patch tries to optimize the number of packages send by pre-building the complete batch of pipelined requests into one big buffer.
Also, the write handling is improved so that successful writing doesn't rely any more on the send buffer size (and network condition). Instead, the request buffer is written in chunks when the network allows it.