Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Default author for exercises should be hostname #159

Closed
rolandgeider opened this issue Jul 3, 2015 · 5 comments
Closed

Default author for exercises should be hostname #159

rolandgeider opened this issue Jul 3, 2015 · 5 comments
Milestone
1.7

Comments

@rolandgeider
Copy link
Member

At the moment, the author used for exercises when added by an administrator is the hard coded string 'wger.de'. This should be changed to the current hostname so that local installations get sensible data.
@jamessimas
Copy link
Contributor

Looking into this.

jamessimas added a commit to jamessimas/wger that referenced this issue Jul 5, 2015
@jamessimas
Change default exercise author to hostname
c687301 
This is a fix for issue wger-project#159.

Previously, if the administrator did not specify an author when
creating a new exercise, the author would default to ‘wger.de’. Now, if
the administrator does not specify an author for a new exercise, the
author will default to the hostname that WGER is installed on.
jamessimas added a commit to jamessimas/wger that referenced this issue Jul 5, 2015
@jamessimas
Update test for commit c687301
b00efde 
Commit c687301 fixes issue wger-project#159 by making the default author for new
exercises the hostname of the local computer.

This change updates the test to ensure this is what we test for.
@jamessimas jamessimas mentioned this issue Jul 5, 2015
Merged
jamessimas added a commit to jamessimas/wger that referenced this issue Jul 5, 2015
@jamessimas
Change default exercise author to hostname
b56931a 
This is a fix for issue wger-project#159.

Previously, if the administrator did not specify an author when
creating a new exercise, the author would default to ‘wger.de’. Now, if
the administrator does not specify an author for a new exercise, the
author will default to the hostname that WGER is installed on.

Update test for commit c687301

This commit also updates the test to ensure this is what we test for.
jamessimas added a commit to jamessimas/wger that referenced this issue Jul 5, 2015
@jamessimas
Change default exercise author to hostname
5edaced 
This is a fix for issue wger-project#159.

Previously, if the administrator did not specify an author when
creating a new exercise, the author would default to ‘wger.de’. Now, if
the administrator does not specify an author for a new exercise, the
author will default to the hostname that WGER is installed on.

This commit also updates the test to ensure this is what we test for.
@jamessimas
Copy link
Contributor

I've just learned what interactive rebasing is, so my future pull requests should be cleaner. Huzzah!

James

@rolandgeider
Copy link
Member Author

I know that some projects practically demand to rebase everything for push requests, but I am more relaxed, if you needed 5 commits, then I get those 5 commits, they don't hurt. But obviously, if you want to tidy up the commits, feel free! 😄 (BTW, you can also rebase commits in a pull request after you have opened it, even multiple times)

@jamessimas
Copy link
Contributor

Good to know. Thanks.!

@rolandgeider
Copy link
Member Author

Implemented with pull request #166

@rolandgeider rolandgeider added this to the 1.7 milestone Jul 8, 2015
@pyup-vuln-bot pyup-vuln-bot mentioned this issue Dec 27, 2016
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.7
Development

No branches or pull requests
2 participants
@rolandgeider @jamessimas