Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Language filter for exercise comments #450

Closed
jegglestone opened this issue Jan 12, 2020 · 1 comment · Fixed by #557
Closed

Language filter for exercise comments #450

jegglestone opened this issue Jan 12, 2020 · 1 comment · Fixed by #557
Milestone

Comments

@jegglestone
Copy link

https://wger.de/api/v2/exercisecomment/?id=597&page=1

Exercise comments is currently a mix of English and German with no language id field.]

Please could you add a language field like you have in the exercise endpoint so I can get exerisecomment?id=123&language=2

Thanks

@rolandgeider
Copy link
Member

the exercise comments have no language filter on themselves, the language is set on the exercises.

TODO: see if it is possible to add to filterset_fields foreign keys like in django's own ORM

Rkamath2 added a commit to Rkamath2/wger that referenced this issue Nov 22, 2020
@rolandgeider rolandgeider linked a pull request Nov 23, 2020 that will close this issue
rolandgeider added a commit that referenced this issue Nov 23, 2020
@rolandgeider rolandgeider added this to the 2.0 milestone Nov 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants