possible feature ? BMI on Graph

[sinedo]

Although the BMI is not as good as other measurements it gives you a rough estimate where your weight should be located
It would be cool to have a checkbox which enables the a transparent color of the bmi displayed in the background of the graph

[rolandgeider]

Yeah, this sounds useful

[Svn-Sp]

@rolandgeider I'm new to Github, but I'd like to try this one.

[rolandgeider]

Hi @Svn-Sp ! Sure, do you have a working development instance? I still haven't uploaded the new Docker images... 🙈 We can coordinate us in the gitter channel, or here if you want

[Svn-Sp]

Have installed wger for developement, but when I go to the weight overview page I just get the table but no graph...

[rolandgeider]

Strange, if you have entries there, it should show you something. Does the development server show 404 errors?

[Svn-Sp]

There are no 404's in the console...

[rolandgeider]

I'll take a look at master. I've been working on a different branch with mobile templates (which I'll hope I'll be able to merge soon) and there it's definitely working

[rolandgeider]

I've merged the branch into master and the weight overview is working (other things are ugly, but should still be functional). The CSS/JS libraries are downloaded with yarn now, the easiest thing is probably to use docker-compose, but you can download the dependencies yourself with yarn install

[Svn-Sp]

Excuse me if this isn't the smartest question, but could you post the complete yarn install command?
I still can't get the graphs to show...

[rolandgeider]

yarn install is the whole command 😄. You call it from the source folder and it should download everything to wger/core/static/yarn/

I really can't think of a reason why it wouldn't show anything

[Svn-Sp]

Still the same problem; No graph is showing and no 404's in the console.
I think yarn install did not work properly

There is still no /yarn folder in wger/core/static !

[rolandgeider]

it's strange that yarn says there's a lock from another package manager, did you pull the latest stuff from master? What does git log -2 say?

[Svn-Sp]

Ok, so I don't really know how I did it, but now it runs! I am gonna start working on the feature now.
Thank you for your patience!

[Svn-Sp]

How shall I implement this, I mean should I draw the lines in the svg or has d3 a function for this or what should I do?

[rolandgeider]

Ok, so I don't really know how I did it, but now it runs! I am gonna start working on the feature now.
Thank you for your patience!

😂😂 I feel you. When it suddenly starts (or stops) working and you don't know why...

[rolandgeider]

For the weight chart we use metricsgraphics, you can look there if it is possible to draw on top of an existing chart. D3 is used in the background, perhaps it's possible to access that?

[Svn-Sp]

Have opened a PR...

[rolandgeider]

PR was merged, closing here