-
-
Notifications
You must be signed in to change notification settings - Fork 584
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/ingredient images #1001
Merged
rolandgeider
merged 4 commits into
wger-project:feature/ingredient-images
from
olijzenga:feature/ingredient-images
Apr 8, 2022
Merged
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
64 changes: 64 additions & 0 deletions
64
wger/nutrition/management/commands/download-off-ingredient-images.py
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,64 @@ | ||
# -*- coding: utf-8 *-* | ||
|
||
# This file is part of wger Workout Manager. | ||
# | ||
# wger Workout Manager is free software: you can redistribute it and/or modify | ||
# it under the terms of the GNU Affero General Public License as published by | ||
# the Free Software Foundation, either version 3 of the License, or | ||
# (at your option) any later version. | ||
# | ||
# wger Workout Manager is distributed in the hope that it will be useful, | ||
# but WITHOUT ANY WARRANTY; without even the implied warranty of | ||
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the | ||
# GNU General Public License for more details. | ||
# | ||
# You should have received a copy of the GNU Affero General Public License | ||
|
||
# Standard Library | ||
import datetime | ||
|
||
# Django | ||
from django.conf import settings | ||
from django.contrib.sites.models import Site | ||
from django.core import mail | ||
from django.core.management.base import BaseCommand | ||
from django.template import loader | ||
from django.utils import translation | ||
from django.utils.translation import gettext_lazy as _ | ||
|
||
# wger | ||
from wger.nutrition.models import MealItem | ||
|
||
|
||
class Command(BaseCommand): | ||
""" | ||
Download images of all Open Food Facts ingredients that are used in a nutrition plan | ||
""" | ||
|
||
help = 'Download images of all Open Food Facts ingredients that are used in a nutrition plan' | ||
|
||
def handle(self, **options): | ||
# Make sure off downloads are enabled | ||
settings.WGER_SETTINGS['DOWNLOAD_FROM_OFF'] = True | ||
|
||
# Since each MealItem is linked to a NutritionPlan via a Meal we can skip accessing | ||
# NutritionPlan and Meal itself and fetch all MealItems directly instead. | ||
meal_items = MealItem.objects.all() | ||
meal_item_counter = 0 | ||
download_counter = 0 | ||
for meal_item in meal_items: | ||
if meal_item.ingredient.fetch_image(): | ||
download_counter += 1 | ||
meal_item_counter += 1 | ||
|
||
if meal_item_counter % 10 == 0: | ||
self.stdout.write( | ||
f'Processed {meal_item_counter} meal items, ' | ||
f'downloaded {download_counter} images' | ||
) | ||
|
||
|
||
self.stdout.write( | ||
f'Processed {meal_item_counter} meal items, downloaded {download_counter} images' | ||
) | ||
self.stdout.write(f'Done') |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,14 @@ | ||
# Generated by Django 3.2.12 on 2022-04-06 18:21 | ||
|
||
from django.db import migrations | ||
|
||
|
||
class Migration(migrations.Migration): | ||
|
||
dependencies = [ | ||
('nutrition', '0010_logitem_meal'), | ||
('nutrition', '0010_merge_0009_auto_20210802_1526_0009_meal_name'), | ||
] | ||
|
||
operations = [ | ||
] |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can't we just do
if ingredient.image:
here?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tried this but in that case RelatedObjectDoesNotExist is raised when the image is not there. The recommended way by Django to work around this is by using hasattr (according to https://docs.djangoproject.com/en/4.0/topics/db/examples/one_to_one/).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you are right