Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configuring django axes #1143

Merged
merged 13 commits into from
Oct 13, 2022
Merged

Conversation

RohanKaran
Copy link
Contributor

@RohanKaran RohanKaran commented Oct 10, 2022

Proposed Changes

Please check that the PR fulfills these requirements

  • Tests for the changes have been added (for bug fixes / features)
  • Added yourself to AUTHORS.rst

Other questions

  • Do users need to run some commmands in their local instances due to this PR
    (e.g. database migration)?
  • python manage.py migrate

@RohanKaran RohanKaran changed the title Add django axes Configuring django axes Oct 10, 2022
@RohanKaran RohanKaran marked this pull request as draft October 10, 2022 20:41
@RohanKaran RohanKaran marked this pull request as ready for review October 10, 2022 21:25
@rolandgeider
Copy link
Member

It would be nice if we would allow docker users to configure this feature, can you add these settings to extras/docker/development/settings.py ? I'd use the same name for the environmental variables

AXES_ENABLED = True -> allow to disable axes entirely (e.g. if this is run in a local network or so we would save up some resources), but default it true
AXES_FAILURE_LIMIT = 5 -> configurable, default is 5
AXES_COOLOFF_TIME = 0.5 -> configurable, default is 0.5
AXES_HANDLER = 'axes.handlers.cache.AxesCacheHandler -> configurable, but default is the cache handler

@RohanKaran
Copy link
Contributor Author

Just these settings or all the settings related to axes ???

@rolandgeider
Copy link
Member

I'd say only these, the others can stay the same for all Installations

@RohanKaran
Copy link
Contributor Author

I'd say only these, the others can stay the same for all Installations

done

@rolandgeider rolandgeider merged commit 5e3167e into wger-project:master Oct 13, 2022
@rolandgeider
Copy link
Member

Merged, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

No protection against bruteforce attacks on login page
2 participants