Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds latest weight details to overview #147

Merged
merged 4 commits into from
Jun 7, 2015

Conversation

yuyu-aung
Copy link
Contributor

No description provided.

@rolandgeider
Copy link
Member

Ah, I see, those are coding style errors. "pep8" is more or less the official coding style for python projects with the idea that when you switch between projects, the code layout remains the same. There is a tool, also called pep8, that automatically checks the code. You can install it in your virtual environment (pip install pep8) and then just do pep8 wger. The errors should be self explaining and once you have corrected a couple, you'll format the code automatically.

@rolandgeider
Copy link
Member

And another thing, don't forget to add yourself to AUTHORS.rst :)

@@ -38,6 +38,24 @@
<div id="weight_diagram"></div>

{% if is_owner %}
{% if last_five_weight_entries_details %}
<table border="1" style="width:100%">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

better do here <table class="table">, we can use the bootstrap CSS classes

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, incorporating it now.

rolandgeider added a commit that referenced this pull request Jun 7, 2015
Adds latest weight details to overview
@rolandgeider rolandgeider merged commit 5f22108 into wger-project:master Jun 7, 2015
@rolandgeider
Copy link
Member

Looks good!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants