Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EMAIL_USE_TLS or EMAIL_USE_SSL #1514

Merged
merged 2 commits into from
Dec 5, 2023
Merged

EMAIL_USE_TLS or EMAIL_USE_SSL #1514

merged 2 commits into from
Dec 5, 2023

Conversation

bbkz
Copy link
Contributor

@bbkz bbkz commented Dec 2, 2023

The default settings.py in the docker image has a error and gives the following Message:

ValueError: EMAIL_USE_TLS/EMAIL_USE_SSL are mutually exclusive, so only set one of those settings to True.
  • EMAIL_USE_TLS is for starttls on the submission port
  • EMAIL_USE_SSL is for the old dedicated ssl port

Proposed Changes

  • as most mailservers now use the submission port i suggest setting EMAIL_USE_TLS as a default.

@bbkz
EMAIL_USE_TLS or EMAIL_USE_SSL
af30c2a 
EMAIL_USE_TLS/EMAIL_USE_SSL are mutually exclusive, so only set one of those settings to True.
@bbkz
Merge pull request #1 from bbkz/bbkz-patch-1
e5c74eb 
EMAIL_USE_TLS or EMAIL_USE_SSL
@rolandgeider
Copy link
Member

oh good catch

@rolandgeider rolandgeider merged commit 3d31862 into wger-project:master Dec 5, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bbkz @rolandgeider