Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix generator for workouts for comment to name rename. #696

Merged
merged 2 commits into from
Jun 6, 2021
Merged

Fix generator for workouts for comment to name rename. #696

merged 2 commits into from
Jun 6, 2021

Conversation

sysadmin75
Copy link
Contributor

@sysadmin75 sysadmin75 commented Jun 6, 2021 •
edited
Loading

Proposed Changes

Please check that the PR fulfills these requirements

  • Tests for the changes have been added (for bug fixes / features)
  • New python code has been linted with with flake8 (flake8 --config .github/linters/.flake8 ./wger/extras/dummy_generator/generator.py`) and isort (isort``)
  • Added yourself to AUTHORS.rst

Other questions

  • Does this PR introduce a breaking change such as a database migration? (i.e.
    what changes might users need to make in their running application due to
    this PR?)

@sysadmin75
Copy link
Contributor Author

Checked off Tests task because all tests in wger.manager passed.

@rolandgeider
Copy link
Member

Thanks!

@rolandgeider rolandgeider merged commit 82bf1ca into wger-project:master Jun 6, 2021
@sysadmin75 sysadmin75 deleted the workout_generator_name_fix branch June 6, 2021 19:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sysadmin75 @rolandgeider