Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix response for Daily calories calculator #772

Merged
merged 1 commit into from
Aug 22, 2021

Conversation

Gr8ayu
Copy link
Contributor

@Gr8ayu Gr8ayu commented Aug 21, 2021

on submitting form from calories calculator for invalid data server was returning empty response, fixed that issue to return valid error messages

Proposed Changes

  • return error message in case of invalid form data

Please check that the PR fulfills these requirements

  • Tests for the changes have been added (for bug fixes / features)
  • Added yourself to AUTHORS.rst

Other questions

  • Do users need to run some commmands in their local instances due to this PR
    (e.g. database migration)?
    No

on submitting form from calories calulator for invalid data server
was returning empty response, fixed that issue to return valid error
messages
@rolandgeider
Copy link
Member

Looks good, thanks!

@rolandgeider rolandgeider merged commit d908b90 into wger-project:master Aug 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants