Add foreign key to meals on log #842
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rolandgeider
requested changes
Oct 3, 2021
wger/nutrition/models/meal.py
Outdated
| null=True, | ||
| on_delete=models.SET_NULL, | ||
| related_name="meals" | ||
| ) |
There was a problem hiding this comment.
The foreign key should be in the logs, sorry if it wasn't very clear. Then in _logMealPlan you can simply set the current meal when creating the LogItem instance
There was a problem hiding this comment.
ah okay okay. sorry my bad i'll get it sorted
|
I'll review this later today or tomorrow at the latest |
Alig1493
force-pushed
the
819-log_meals
branch
from
cf0838f
to
9eaedea
Compare
rolandgeider
reviewed
Oct 7, 2021
wger/nutrition/forms.py
Outdated
| @@ -263,13 +263,15 @@ def __init__(self, *args, **kwargs): | |||
|
|
|||
|
|
|||
| class MealLogItemForm(MealItemForm): | |||
| meal = forms.ModelChoiceField(queryset=Meal.objects.all(), required=False) | |||
There was a problem hiding this comment.
actually, now that I'm thinking about it, better remove the meal from this form, then I can merge the PR
rolandgeider
approved these changes
Oct 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
log_itemtoMealsmodel inside nutritionlogitemsupon creating logs.Please check that the PR fulfills these requirements
Other questions
(e.g. database migration)?
#819