Find a driver instance under WebElement object #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@kejkz, thanks for contribution! Looks fine for me. |
|
@SUNx2YCH I've actually just pushed the proposed change, with the custom installation of the Thank you for the fine library |
|
@SUNx2YCH sure, np |
kejkz
force-pushed
the
find-element-driver-instance
branch
from
159de1d
to
d52db28
Compare
|
@SUNx2YCH Done! Thanks again for the effort. |
|
@kejkz, this change is now a part of Thanks again for contribution. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the ability to fetch the driver instance directly from the WebElement object and do not try to initialize the new driver instance if
_driverattribute does not exist. This is needed if custom driver instance is used while initializing the Webium page objects.