Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: license url to license type mapping #72

Merged
merged 27 commits into from
Apr 25, 2022
Merged

Conversation

wgnf
Copy link
Owner

@wgnf wgnf commented Apr 14, 2022

📫 Addressed Issue(s)

📄 Description

This will add the ability to provide a license-url to license-type mapping. Also a little rework regarding license-type-definitions, to follow one concept for all these types of mappings and files.

TODOs:

  • add settings for license-url to license-type mappings (file and dictionary)
  • add file-setting for license-type-definition file
  • add deserialization for icense-type-definition file
  • Update license-type-definition docs (LicenseTypeDefinitionsFilePath)
  • Feature similar to license-type-definitions:
    • preprocessor to deserialize
    • url-mapping-provider
      • provider with default values
      • provider with settings values
    • ILicenseInformationSource
    • update docs for new setting
  • test both things for real
  • update integration tests(?)
  • update README

✅ Checks

  • My PR adheres to the general code-style of this project (look at other code if you're unsure)
  • My code requires changes to the documentation
  • I have updated the documentation as required
  • All the automated tests have passed

@codecov
Copy link

codecov bot commented Apr 14, 2022

Codecov Report

Merging #72 (1e244c3) into main (9f682f7) will increase coverage by 1.04%.
The diff coverage is 99.40%.

@@            Coverage Diff             @@
##             main      #72      +/-   ##
==========================================
+ Coverage   95.50%   96.54%   +1.04%     
==========================================
  Files          38       48      +10     
  Lines        1400     1851     +451     
==========================================
+ Hits         1337     1787     +450     
- Misses         63       64       +1     
Impacted Files Coverage Δ
...LicenseType/ApacheLicenseTypeDefinitionProvider.cs 100.00% <ø> (ø)
...es/LicenseType/BsdLicenseTypeDefinitionProvider.cs 100.00% <ø> (ø)
...s/LicenseType/CddlLicenseTypeDefinitionProvider.cs 100.00% <ø> (ø)
...es/LicenseType/EplLicenseTypeDefinitionProvider.cs 100.00% <ø> (ø)
...s/LicenseType/EuplLicenseTypeDefinitionProvider.cs 100.00% <ø> (ø)
...es/LicenseType/GnuLicenseTypeDefinitionProvider.cs 100.00% <ø> (ø)
...eType/LicenseTypeDefinitionFromSettingsProvider.cs 100.00% <ø> (ø)
...enseType/MicrosoftLicenseTypeDefinitionProvider.cs 100.00% <ø> (ø)
...es/LicenseType/MplLicenseTypeDefinitionProvider.cs 100.00% <ø> (ø)
...es/LicenseType/NplLicenseTypeDefinitionProvider.cs 100.00% <ø> (ø)
... and 16 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9f682f7...1e244c3. Read the comment docs.

@wgnf wgnf marked this pull request as ready for review April 25, 2022 17:34
…apping

# Conflicts:
#	src/Tool/Liz.Tool/Liz.Tool.csproj
@wgnf wgnf merged commit 9cc6100 into main Apr 25, 2022
@wgnf wgnf deleted the feature/url-to-type-mapping branch April 25, 2022 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEAT]: URL to license-information (license-type) mapping
1 participant