Skip to content

Commit

Permalink
plugin/emacs: Don't use region intersection in Flymake while reporting
Browse files Browse the repository at this point in the history
This is causing diagnostics to not be cleared sometimes (see quick-lint#398), it
was first introduced for developement, because restarting Flymake
without changes in buffers would not delete old diagnostics, I think
it's fine if we not specify this option.

However I suspect this is a bug in Flymake.

Signed-off-by: wagner riffel <w@104d.net>
(cherry picked from commit 6a223f8)
  • Loading branch information
wgrr committed Aug 5, 2021
1 parent 3a01bdd commit 387222b
Showing 1 changed file with 1 addition and 2 deletions.
3 changes: 1 addition & 2 deletions plugin/emacs/flymake-quicklintjs.el
Original file line number Diff line number Diff line change
Expand Up @@ -87,8 +87,7 @@ REPORT-FN is Flymake's callback."
(buffer-substring-no-properties
(point-min) (point-max)))))))
(if (or diags (zerop (process-exit-status p)))
(funcall report-fn diags
:region (cons (point-min) (point-max)))
(funcall report-fn diags)
(funcall report-fn
:panic :explanation
(buffer-substring
Expand Down

0 comments on commit 387222b

Please sign in to comment.