-
Notifications
You must be signed in to change notification settings - Fork 37
Agent to teardown sessions on signals #2077
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r1.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @ip1981 and @utopiabound)
iml-agent/src/main.rs, line 48 at r1 (raw file):
pooler, pooler_reg
Typos: poller
f625360
to
112a817
Compare
iml-agent/src/main.rs
Outdated
futures::select! { | ||
() = sigterm.recv().fuse().map(drop) => (), | ||
() = sigint.recv().fuse().map(drop) => () | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably we could make a utility function:
async fn main () {
// spawn
signals().await;
// clean up
}
Has a conflict on latest master |
Signed-off-by: Igor Pashev <pashev.igor@gmail.com>
112a817
to
1f00528
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r3.
Reviewable status: all files reviewed, 3 unresolved discussions (waiting on @ip1981, @jgrund, and @utopiabound)
Signed-off-by: Igor Pashev <pashev.igor@gmail.com> Co-authored-by: Joe Grund <jgrund@whamcloud.io>
Closes #1476.
Signed-off-by: Igor Pashev pashev.igor@gmail.com
This change is