Skip to content
This repository has been archived by the owner on Jul 25, 2022. It is now read-only.

Disable default features of reqwest #2098

Merged
merged 2 commits into from
Jul 29, 2020
Merged

Disable default features of reqwest #2098

merged 2 commits into from
Jul 29, 2020

Conversation

mkpankov
Copy link
Contributor

@mkpankov mkpankov commented Jul 22, 2020

Default features enable default-tls which is native-tls

Signed-off-by: Michael Pankov work@michaelpankov.com


This change is Reviewable

@mkpankov mkpankov self-assigned this Jul 22, 2020
@mkpankov mkpankov marked this pull request as draft July 22, 2020 10:17
@mkpankov mkpankov closed this Jul 22, 2020
@mkpankov mkpankov reopened this Jul 22, 2020
@mkpankov mkpankov marked this pull request as ready for review July 28, 2020 09:01
@mkpankov mkpankov added this to the IML EX V3 milestone Jul 28, 2020
@mkpankov mkpankov requested review from jgrund and a team July 28, 2020 09:01
ip1981
ip1981 previously approved these changes Jul 28, 2020
@jgrund
Copy link
Member

jgrund commented Jul 28, 2020

I would have expected the Cargo.lock file to change to remove native-tls as part of this patch:

Is it still being included somehow?

@jgrund
Copy link
Member

jgrund commented Jul 28, 2020

It's because influx_db_client is using it.

If you update

to influx_db_client = {version = "0.4", default-features = false, features = ["rustls-tls"]}

Then the Cargo.lock file will also update

It enables default-tls which is native-tls

Signed-off-by: Michael Pankov <work@michaelpankov.com>
Signed-off-by: Michael Pankov <work@michaelpankov.com>
@jgrund jgrund requested a review from ip1981 July 29, 2020 12:24
@jgrund jgrund merged commit 67d1e50 into master Jul 29, 2020
@jgrund jgrund deleted the rustls branch July 29, 2020 15:44
beevans pushed a commit to beevans/integrated-manager-for-lustre that referenced this pull request Aug 6, 2020
* Disable default features of reqwest

It enables default-tls which is native-tls

Signed-off-by: Michael Pankov <work@michaelpankov.com>

* Disable native-tls in influx_db_client

Signed-off-by: Michael Pankov <work@michaelpankov.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants