This repository has been archived by the owner on Jul 25, 2022. It is now read-only.
Simplify Snapshot structure #2222
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ip1981
force-pushed
the
ip1981/snapshot-deflate
branch
from
63c2663
to
665287f
Compare
jgrund
reviewed
Sep 7, 2020
| "not mount" => Some(Status::NotMounted), | ||
| let mounted = match status.as_str() { | ||
| "mounted" => Some(true), | ||
| "not mount" => Some(false), | ||
| _ => None, |
There was a problem hiding this comment.
There was a problem hiding this comment.
Updated:
let mounted = match status.as_str() {
"mounted" => Some(true),
"not mount" => Some(false),
"unknown" => None,
_ => return Err("mounted, not mount, unknown"),
};
ip1981
force-pushed
the
ip1981/snapshot-deflate
branch
from
665287f
to
3d3aadb
Compare
mkpankov
previously approved these changes
Sep 7, 2020
There was a problem hiding this comment.
Reviewed 6 of 7 files at r1, 1 of 1 files at r2.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @jgrund)
|
This has conflicts on master. |
Don't need detailed views Signed-off-by: Igor Pashev <pashev.igor@gmail.com>
ip1981
force-pushed
the
ip1981/snapshot-deflate
branch
from
3d3aadb
to
fd1ab20
Compare
mkpankov
approved these changes
Sep 7, 2020
There was a problem hiding this comment.
Reviewed 2 of 2 files at r3.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @jgrund)
jgrund
approved these changes
Sep 8, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't need detailed views
Signed-off-by: Igor Pashev pashev.igor@gmail.com
This change is