This repository has been archived by the owner on Jul 25, 2022. It is now read-only.
Add list snapshot interval GUI #2253
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch adds a new GUI component for listing snapshot intervals. It also refactors the snapshot GUI code to split it into separate files as it was getting a bit unwieldly. Signed-off-by: Joe Grund <jgrund@whamcloud.io>
ip1981
previously approved these changes
Sep 18, 2020
Signed-off-by: Joe Grund <jgrund@whamcloud.io>
ip1981
approved these changes
Sep 18, 2020
mkpankov
approved these changes
Sep 21, 2020
There was a problem hiding this comment.
Reviewed 7 of 7 files at r1.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @jgrund)
ip1981
reviewed
Sep 21, 2020
| ) | ||
| } | ||
|
|
||
| fn display_interval(x: Duration) -> String { |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch adds a new GUI component for listing
snapshot intervals.
It also refactors the snapshot GUI code to split it into separate files
as it was getting a bit unwieldy.
Signed-off-by: Joe Grund jgrund@whamcloud.io
This change is