Skip to content
This repository has been archived by the owner on Jul 25, 2022. It is now read-only.

Add snapshot retention ops to CLI #2267

Merged
merged 1 commit into from
Sep 24, 2020
Merged

Conversation

ip1981
Copy link
Member

@ip1981 ip1981 commented Sep 23, 2020

[root@adm ~]# iml snapshot retention create zfsmo 50 g 10
[root@adm ~]# iml snapshot retention list
+----+------------+---------+------+----------+
| Id | Filesystem | Reserve | Keep | Last Run |
+====+============+=========+======+==========+
| 5  | zfsmo      | 50 GiB  | 10   | --       |
+----+------------+---------+------+----------+

[root@adm ~]# iml snapshot retention create zfsmo 10 % 10
[root@adm ~]# iml snapshot retention list
+----+------------+---------+------+----------+
| Id | Filesystem | Reserve | Keep | Last Run |
+====+============+=========+======+==========+
| 5  | zfsmo      | 10 %    | 10   | --       |
+----+------------+---------+------+----------+

Signed-off-by: Igor Pashev pashev.igor@gmail.com


This change is Reviewable

@ip1981 ip1981 requested a review from a team September 23, 2020 15:33
@ip1981 ip1981 self-assigned this Sep 23, 2020
delete_num: i32,
delete_unit: DeleteUnit,
reserve_value: i32,
reserve_unit: ReserveUnit,
keep_num: i32,
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is inconsistently optional here and there.

@ip1981 ip1981 force-pushed the ip1981/ex-1750-cli-snap-retention branch 5 times, most recently from e722cc4 to c40bf7d Compare September 23, 2020 15:42
@ip1981 ip1981 marked this pull request as ready for review September 23, 2020 15:43
@ip1981 ip1981 force-pushed the ip1981/ex-1750-cli-snap-retention branch 3 times, most recently from b336ab4 to a83d068 Compare September 23, 2020 16:21
Copy link
Member

@jgrund jgrund left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a typo for the SnapshotRetentionPolicies query.

@ip1981 ip1981 force-pushed the ip1981/ex-1750-cli-snap-retention branch 2 times, most recently from 229be3e to fce7e38 Compare September 24, 2020 14:54
@ip1981 ip1981 marked this pull request as draft September 24, 2020 14:54
Signed-off-by: Igor Pashev <pashev.igor@gmail.com>
@ip1981 ip1981 force-pushed the ip1981/ex-1750-cli-snap-retention branch from fce7e38 to 0acb65e Compare September 24, 2020 16:04
@ip1981 ip1981 marked this pull request as ready for review September 24, 2020 16:04
@jgrund jgrund merged commit 1f4977f into master Sep 24, 2020
@jgrund jgrund deleted the ip1981/ex-1750-cli-snap-retention branch September 24, 2020 16:22
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants