Add pinch-zoom token to touch-action property? #68

Closed
RByers opened this Issue Dec 20, 2016 · 2 comments

Comments

2 participants
@RByers
Contributor

RByers commented Dec 20, 2016

The touch-action property defines a number of tokens. Edge and Chrome also ship an additional pinch-zoom token (and I believe Firefox plans to as well /cc @staktrace). But it's not clear if this will ever make it into the W3C PointerEvents spec.

I think it's particularly important that we increase the visibility of this property (eg. document it on MDN for accessibility reasons. Many image carousels already use touch-action: pan-y when they probably should be using touch-action: pan-y pinch-zoom in order to avoid disabling zooming for vision impared users.

It'll be a little awkward to monkey patch it in, but is it OK if I submit a PR for this?
/cc @dtapuska @teddink @NavidZ @mustaqahmed

@RByers

This comment has been minimized.

Show comment
Hide comment
@RByers

RByers Dec 20, 2016

Contributor

Concretely I believe the grammar should change from:
auto | none | [ [ pan-x | pan-left | pan-right ] || [ pan-y | pan-up | pan-down ] ] | manipulation
To:
auto | none | [ [ pan-x | pan-left | pan-right ] || [ pan-y | pan-up | pan-down ] || pinch-zoom ] | manipulation

I.e. pinch-zoom may optionally be specified along with the existing pan values (or by itself), but not in combination with auto, none or manipulation.

manipulation then becomes a synonym for pan-x pan-y pinch-zoom.

Contributor

RByers commented Dec 20, 2016

Concretely I believe the grammar should change from:
auto | none | [ [ pan-x | pan-left | pan-right ] || [ pan-y | pan-up | pan-down ] ] | manipulation
To:
auto | none | [ [ pan-x | pan-left | pan-right ] || [ pan-y | pan-up | pan-down ] || pinch-zoom ] | manipulation

I.e. pinch-zoom may optionally be specified along with the existing pan values (or by itself), but not in combination with auto, none or manipulation.

manipulation then becomes a synonym for pan-x pan-y pinch-zoom.

@miketaylr

This comment has been minimized.

Show comment
Hide comment
@miketaylr

miketaylr Dec 20, 2016

Collaborator

Assuming this is something Gecko wants to ship eventually (or should otherwise be convinced to...), +1.

Collaborator

miketaylr commented Dec 20, 2016

Assuming this is something Gecko wants to ship eventually (or should otherwise be convinced to...), +1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment