Add touch-action pinch-zoom value #70
Conversation
| Media: visual | ||
| </pre> | ||
|
|
||
| When specified, the <code>pinch-zoom</code> token enables two-finger panning and zooming of the page. |
There was a problem hiding this comment.
Should this be multi-finger? And all fingers? I believe in Chrome we test > 1 and you can pinch-zoom with 3 or more fingers as well.
There was a problem hiding this comment.
Sure, done. I don't want to try to go into a ton of detail here, but that does seem to better reflect the state of implementations today than pretending that "two" is somehow special.
|
Bikeshed-foo LGTM. @RByers care to add yourself to the Acknowledgements (optional, of course)? |
|
lgtm |
|
LGTM as well. |
Actually, I'm just gonna do that post-merge. 💃 |
Done, thanks! |
|
Whoops too slow. Ok I'll leave it to you. |
|
Heh, sorry for being impatient -- already pushed. |
No issue. Add @RByers to acks. Add touch-action pinch-zoom value ( whatwg/compat#70 ) whatwg/compat@9a07026 0527ac97 Update README - fix Bikeshed link ( whatwg/compat#69 ) No issue. Add @chenpighead to acknowledgements. Fixes Issue whatwg/compat#67. Use absolute length (rather than width) for computed… whatwg/compat@f969bef 2492a5af No issue. Regen compatibility.html after updating bikeshed and fixing… No issue. Tell bikeshed to not complaint about issues-index. No issue. Fix minor linking warnings. No issue. Add ids to examples. Fixes whatwg/compat#66 . Use Animation type in propdef tables. whatwg/compat@6040745 eb777f41
Fixes #68
Preview here
/cc @dtapuska @mustaqahmed @staktrace
@miketaylr my Bikeshed-foo is weak, feel free to suggest improvements. Also note that there are some subtle details about
pinch-zoomsemantics and complexities in thetouch-actionprocessing model that make this pretty hard to explain super rigorously. My plan here is to focus on getting standard automated input testing working inweb-platform-testso we can describe exactly what we mean in tests, while continuing to tweak spec text to be more precise.