Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing "queue a global task" to resolve Promise in abort example #1300

Closed
tidoust opened this issue Aug 1, 2024 · 1 comment · Fixed by #1305
Closed

Missing "queue a global task" to resolve Promise in abort example #1300

tidoust opened this issue Aug 1, 2024 · 1 comment · Fixed by #1305

Comments

@tidoust
Copy link

tidoust commented Aug 1, 2024

What is the issue with the DOM Standard?

The example on using AbortController and AbortSignal objects should queue a global task to resolve p with amazingResult (step 3.2).

That's sort of already recorded in #1031 (comment) but I wasn't clear whether that comment was really about this, so I thought I would create a dedicated issue.

FWIW, step 2.3.2 seems correct to me since abort steps run within a global task.

Via w3c/strudy#663 where I've started to look into automating detection of such hiccups in specs (although not in examples)

annevk added a commit that referenced this issue Aug 13, 2024
As this is a frequently made error, having it wrong in DOM does the community a disservice.

Fixes #1300.
@annevk
Copy link
Member

annevk commented Aug 13, 2024

That sounds really cool, hope it works out! If you could review #1305 I'd appreciate it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging a pull request may close this issue.

2 participants