Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update WebIDL definition(s) to use new mixin syntax #532

Closed
6 tasks
tobie opened this issue Nov 3, 2017 · 0 comments · Fixed by web-platform-tests/wpt#8700 or #545
Closed
6 tasks

Update WebIDL definition(s) to use new mixin syntax #532

tobie opened this issue Nov 3, 2017 · 0 comments · Fixed by web-platform-tests/wpt#8700 or #545

Comments

@tobie
Copy link
Contributor

tobie commented Nov 3, 2017

Hi all!

WebIDL recently introduced dedicated syntax for mixins.

This syntax replaces the [NoInterfaceObject] extended attribute and implements statement which have been deprecated (except for a few legacy uses cases explicitely mentioned in the spec).

You can read more about it here.

In most cases, the changes should be relatively straightforward. The now deprecated:

interface Foo { };

[NoInterfaceObject]  // (Mostly) DEPRECATED
interface Bar { };
Foo implementes Bar; // DEPRECATED

should just be rewritten as:

interface Foo { };

interface mixin Bar { };
Foo includes Bar;

Additonaly, a section on when to use partials and mixins has been added to the spec. It's short and might be worth a read.

It seems the following interfaces in this spec are impacted by this change:

  • NonElementParentNode
  • DocumentOrShadowRoot
  • ParentNode
  • NonDocumentTypeChildNode
  • ChildNode
  • Slotable

We're sorry for the inconvenience this causes, but our hope is that this ultimately makes things simpler and clearer for everybody.

As always, please feel free to reach out if you have any questions.

Thanks!

Tracked in: whatwg/webidl#472 | Original pull-request: whatwg/webidl#433
This was referenced Nov 3, 2017
Closed
Closed
romandev added a commit to romandev/dom that referenced this issue Dec 15, 2017
@romandev
Use interface mixins instead of [NoInterfaceObject]
a536ecb 
WebIDL recently introduced dedicated syntax for mixins[1]. So, we can
replace `[NoInterfaceObject]` and `implements` with `interface mixin` and
`includes`.

This following interfaces are impacted by this change:
  - NonElementParentNode
  - DocumentOrShadowRoot
  - ParentNode
  - NonDocumentTypeChildNode
  - ChildNode
  - Slotable

This fixes whatwg#532 issue.

[1] whatwg/webidl@45e8173
This was referenced Dec 15, 2017
Merged
Merged
annevk pushed a commit to web-platform-tests/wpt that referenced this issue Dec 18, 2017
@romandev @annevk
Use new mixin syntax dom.idl
8d55e38 
Helps with whatwg/dom#532.
romandev added a commit to romandev/dom that referenced this issue Dec 18, 2017
@romandev
Use interface mixins instead of [NoInterfaceObject]
f632cf2 
WebIDL recently introduced dedicated syntax for mixins[1]. So, we can
replace `[NoInterfaceObject]` and `implements` with `interface mixin` and
`includes`.

This following interfaces are impacted by this change:
  - NonElementParentNode
  - DocumentOrShadowRoot
  - ParentNode
  - NonDocumentTypeChildNode
  - ChildNode
  - Slotable

This fixes whatwg#532 issue.

[1] whatwg/webidl@45e8173
@annevk annevk reopened this Dec 18, 2017
annevk pushed a commit that referenced this issue Dec 19, 2017
@romandev @annevk
Use interface mixins in IDL
12b0698 
IDL recently introduced dedicated syntax for mixins in whatwg/webidl@45e8173. So, we can replace [NoInterfaceObject] and implements with interface mixin and includes.

This following interfaces are impacted by this change:
- NonElementParentNode
- DocumentOrShadowRoot
- ParentNode
- NonDocumentTypeChildNode
- ChildNode
- Slotable

Tests: web-platform-tests/wpt#8700.

Fixes #532.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
2 participants
@tobie @annevk