Revamp the way DOM talks about nodes #1004
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Address numerous xref issues around the term node and prevent some from occurring for the term children. 2. Embrace Attr as a node even more. 3. Rely on Web IDL's implements and interface primitives to reduce the opportunities for confusion.
sideshowbarker
approved these changes
Aug 3, 2021
domenic
reviewed
Aug 3, 2021
domenic
reviewed
Aug 4, 2021
| <li><p>If <var>node</var> is not a {{DocumentFragment}}, {{DocumentType}}, {{Element}}, {{Text}}, | ||
| {{ProcessingInstruction}}, or {{Comment}} <a for=/>node</a>, then <a>throw</a> a | ||
| <li><p>If <var>node</var> is not a {{DocumentFragment}}, {{DocumentType}}, {{Element}}, or | ||
| {{CharacterData}} <a for=/>node</a>, then <a>throw</a> a |
domenic
approved these changes
Aug 5, 2021
dom.bs
Outdated
|
|
||
| <p>Objects that implement {{DocumentFragment}} sometimes implement {{ShadowRoot}}. | ||
|
|
||
| <p>Objects that <a>implement</a> {{Element}} also typically implement an inherited interface, such |
There was a problem hiding this comment.
The inconsistent linking of "implement" here is a bit confusing. I'd suggest either in every sentence in this note, or in just the first instance.
dom.bs
Outdated
| <dt>{{ProcessingInstruction}} | ||
| <dt>{{Comment}} | ||
| <dt>{{CharacterData}} | ||
| <dt>{{Attr}} | ||
| <dd><p>None. |
There was a problem hiding this comment.
"No allowed children"? I had to go back and re-read the intro paragraph to see what you meant.
dom.bs
Outdated
| <p>To determine the <dfn export id=concept-node-length for=Node>length</dfn> of a <a>node</a> | ||
| <var>node</var>, switch on <var>node</var>: | ||
| <p class=note>{{Attr}} <a for=/>nodes</a> <a>participate</a> in a <a>tree</a> for historical | ||
| reasons; they never have a <a for=tree>parent</a> or <a for=tree>children</a> and are therefore |
There was a problem hiding this comment.
I think "their parent is always null" is a bit more technically accurate. Because https://whatpr.org/dom/1004.html#concept-tree-participate says "An object that participates in a tree has a parent", which seems to contradict this.
I guess technically "never have children" should be "always have an empty set for their children", but that one bothers me much less for some reason.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes whatwg/webidl#659, #597, #636, #719, and #770.
(See WHATWG Working Mode: Changes for more details.)
Preview | Diff