Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add abortController.close / abortSignal.closed #1042

Closed
wants to merge 1 commit into from
Closed

Add abortController.close / abortSignal.closed #1042

wants to merge 1 commit into from
+48 −0

Conversation

jasnell
Copy link
Contributor

@jasnell jasnell commented Dec 8, 2021 •
edited by pr-preview bot
Loading

Refs: #1039

  • At least two implementers are interested (and none opposed):
    • Node.js
    • Cloudflare Workers
  • Tests are written and can be reviewed and commented upon at:
    • …
  • Implementation bugs are filed:
    • Chrome: …
    • Firefox: …
    • Safari: …

(See WHATWG Working Mode: Changes for more details.)

💥 Error: 500 Internal Server Error 💥

PR Preview failed to build. (Last tried on Dec 8, 2021, 7:34 PM UTC).

More

PR Preview relies on a number of web services to run. There seems to be an issue with the following one:

🚨 CSS Spec Preprocessor - CSS Spec Preprocessor is the web service used to build Bikeshed specs.

🔗 Related URL

<!DOCTYPE HTML PUBLIC "-//IETF//DTD HTML 2.0//EN">
<html><head>
<title>500 Internal Server Error</title>
</head><body>
<h1>Internal Server Error</h1>
<p>The server encountered an internal error or
misconfiguration and was unable to complete
your request.</p>
<p>Please contact the server administrator at 
 [no address given] to inform them of the time this error occurred,
 and the actions you performed just before this error.</p>
<p>More information about this error may be available
in the server error log.</p>
<hr>
<address>Apache/2.4.10 (Debian) Server at api.csswg.org Port 443</address>
</body></html>

If you don't have enough information above to solve the error by yourself (or to understand to which web service the error is related to, if any), please file an issue.

@jasnell jasnell mentioned this pull request Dec 8, 2021
Open
@domenic
Copy link
Member

domenic commented Dec 8, 2021

Although the PR here is helpful in seeing a concrete proposal, IMO it is too early to consider adding this, as there are a lot of other possibilities in the design space.

MattiasBuelens
MattiasBuelens reviewed Dec 8, 2021
View reviewed changes
dom.bs
<p>A <var>followingSignal</var> (an {{AbortSignal}}) is made to
<dfn export for=AbortSignal>follow</dfn> a <var>parentSignal</var> (an {{AbortSignal}}) by running
these steps:

<ol>
<li><p>If <var>followingSignal</var> is [=AbortSignal/aborted=], then return.

<li><p>If <var>followingSignal</var> is [=AbortSignal/closed=], then return.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ideally, if followingSignal becomes closed later on, we would remove the abort steps added to parentSignal so we don't unnecessarily keep parentSignal alive.

Not sure how that'll work in practice though. We've already had a similar discussion in #920 (comment).

@jasnell
Copy link
Contributor Author

jasnell commented Dec 9, 2021

Although the PR here is helpful in seeing a concrete proposal, IMO it is too early to consider adding this, as there are a lot of other possibilities in the design space.

Yep! No rush on it, I just wanted to make it a bit more concrete for the discussion

@jasnell jasnell closed this Jan 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MattiasBuelens MattiasBuelens MattiasBuelens left review comments

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jasnell @domenic @MattiasBuelens