-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add more UTF-8, UTF-16BE, and UTF-16LE labels #211
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Blink and WebKit have supported these for a long time. Tests: web-platform-tests/wpt#23427. Fixes #168.
annevk
added a commit
to web-platform-tests/wpt
that referenced
this pull request
May 6, 2020
Through this change, textdecoder-labels.any.js will test the new labels. For whatwg/encoding#211.
hsivonen
suggested changes
May 6, 2020
hsivonen
approved these changes
May 6, 2020
inexorabletash
approved these changes
May 6, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
annevk
added a commit
to web-platform-tests/wpt
that referenced
this pull request
May 6, 2020
Through this change, textdecoder-labels.any.js will test the new labels. For whatwg/encoding#211.
lgtm |
moz-v2v-gh
pushed a commit
to mozilla/gecko-dev
that referenced
this pull request
May 15, 2020
…els, a=testonly Automatic update from web-platform-tests Encoding: align encodings.js with encodings.json Through this change, textdecoder-labels.any.js will test the new labels. For whatwg/encoding#211. -- wpt-commits: 769704e890d36655e5a436ab5d292a902c0b3e91 wpt-pr: 23427
xeonchen
pushed a commit
to xeonchen/gecko
that referenced
this pull request
May 15, 2020
…els, a=testonly Automatic update from web-platform-tests Encoding: align encodings.js with encodings.json Through this change, textdecoder-labels.any.js will test the new labels. For whatwg/encoding#211. -- wpt-commits: 769704e890d36655e5a436ab5d292a902c0b3e91 wpt-pr: 23427
moz-v2v-gh
pushed a commit
to mozilla/gecko-dev
that referenced
this pull request
May 20, 2020
…els, a=testonly Automatic update from web-platform-tests Encoding: align encodings.js with encodings.json Through this change, textdecoder-labels.any.js will test the new labels. For whatwg/encoding#211. -- wpt-commits: 769704e890d36655e5a436ab5d292a902c0b3e91 wpt-pr: 23427
xeonchen
pushed a commit
to xeonchen/gecko
that referenced
this pull request
May 20, 2020
…els, a=testonly Automatic update from web-platform-tests Encoding: align encodings.js with encodings.json Through this change, textdecoder-labels.any.js will test the new labels. For whatwg/encoding#211. -- wpt-commits: 769704e890d36655e5a436ab5d292a902c0b3e91 wpt-pr: 23427
lucacasonato
added a commit
to lucacasonato/encoding_rs
that referenced
this pull request
Jun 4, 2021
hsivonen
pushed a commit
to hsivonen/encoding_rs
that referenced
this pull request
Jun 17, 2021
andreubotella
pushed a commit
to andreubotella/deno
that referenced
this pull request
Oct 28, 2021
This change updates `encoding_rs` to version 0.8.29, which allows us to support the encoding labels added in whatwg/encoding#211. Fixes denoland#10985.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Blink and WebKit have supported these for a long time.
Tests: web-platform-tests/wpt#23427.
Fixes #168.
(See WHATWG Working Mode: Changes for more details.)
Preview | Diff