Fix TextDecoderStream's behavior when processing the end of stream #265
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change fixes TextDecoderStream's "flush and enqueue" algorithm to handle the end of the stream in the same way as a call to TextDecoder's decode method with no parameters. Fixes #263.
andreubotella
added
needs tests
andreubotella
requested review from
ricea and
annevk
and removed request for
ricea
annevk
reviewed
Jun 21, 2021
Co-authored-by: Anne van Kesteren <annevk@annevk.nl>
annevk
approved these changes
Jun 21, 2021
ricea
approved these changes
Jun 21, 2021
annevk
added a commit
to web-platform-tests/wpt
that referenced
this pull request
Jun 24, 2021
|
I created tests for this over at web-platform-tests/wpt#29481. Review welcome! |
annevk
added a commit
to web-platform-tests/wpt
that referenced
this pull request
Jun 24, 2021
annevk
removed
the
needs tests
moz-v2v-gh
pushed a commit
to mozilla/gecko-dev
that referenced
this pull request
Jun 27, 2021
…stonly Automatic update from web-platform-tests Encoding: add some basic EOF tests For whatwg/encoding#265. -- wpt-commits: 9eab9a5f0b8768ee0de824a9d136c7c0da55b4dd wpt-pr: 29481
jamienicol
pushed a commit
to jamienicol/gecko
that referenced
this pull request
Jul 16, 2021
…stonly Automatic update from web-platform-tests Encoding: add some basic EOF tests For whatwg/encoding#265. -- wpt-commits: 9eab9a5f0b8768ee0de824a9d136c7c0da55b4dd wpt-pr: 29481
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change fixes
TextDecoderStream's "flush and enqueue" algorithm to handle the end of the stream in the same way as a call toTextDecoder'sdecodemethod with no parameters.Fixes #263.
TextDecoder's non-streaming mode.(See WHATWG Working Mode: Changes for more details.)
Preview | Diff