Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update RFC 7234 usage to RFC 9111 #1558

Closed
dlrobertson opened this issue Dec 4, 2022 · 6 comments · Fixed by #1587
Closed

Update RFC 7234 usage to RFC 9111 #1558

dlrobertson opened this issue Dec 4, 2022 · 6 comments · Fixed by #1587

Comments

@dlrobertson
Copy link
Member

RFC 7234 has been obsoleted by RFC 9111. Replace links to RFC 7234 with the appropriate sections in RFC 9111.

@dlrobertson
Copy link
Member Author

On a cursory glance things largely look the same. stale-while-revalidate is not listed in Cache Directive Registration, but is still listed in IANA HTTP Cache Directive Registry. I don't really know how changes like this work, so I'm likely missing something.

@annevk
Copy link
Member

annevk commented Dec 4, 2022

One thing I wanted to do as part of this is to acknowledge the new header terminology, which would make this less straightforward than updating the links. (Essentially, HTTP calls most of them fields now and we should probably start using that or at least acknowledge that but say we'll continue using header.)

Something similar might apply to header values as we don't match the RFC there.

And perhaps there's more things?

@dlrobertson
Copy link
Member Author

Ah! Thanks, that is interesting

@mnot
Copy link
Member

mnot commented Dec 5, 2022

FWIW, the HTTP specs use 'header fields' etc. consistently, but also acknowledge that they're often referred to just as 'headers'.

@annevk
Copy link
Member

annevk commented Jan 6, 2023

Let's see:

  • field-name: unchanged.
  • method: unchanged.
  • field-content: unchanged.
  • field-value: changed, but we don't rely on this currently despite it being listed in the source so maybe it doesn't matter. Our restrictions on header values are much looser than HTTP. The note near "header value" needs to reference field-value value space httpwg/http-core#215 though. That's closed, but it's not clear to me the HTTP WG is willing to engage further on this topic.
  • reason-phrase: unchanged, but no longer defined in semantics. I guess it's a pure HTTP/1.1 thing now.
  • delta-seconds: unchanged.

I think most of the tricky issues with fields are avoided because we don't talk about trailers at the moment. If we ever got trailer support it might give rise to some confusion as we'd use header list and Headers for them. As header list and Headers is really our "fields". Still, we should add a note that we use the colloquial term.

Ah, and I just noticed there's a bunch of hardcoded links for HTTP caching as also noted above. Hopefully those are somewhat straightforward.

@annevk
Copy link
Member

annevk commented Jan 9, 2023

#1587 is meant to address this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging a pull request may close this issue.

3 participants