Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editorial: update args for collect an HTTP quoted string #1641

Merged
merged 1 commit into from
May 6, 2023

Conversation

dlrobertson
Copy link
Member

@dlrobertson dlrobertson commented Apr 25, 2023

Rename the "extract-value flag" argument to the algorithm "collect an HTTP quoted string" to a boolean "extract-value" that will by default be false.

Fixes: #1567


Preview | Diff

Copy link
Member

@annevk annevk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for tackling this. Just a couple nits. And maybe we should link the downstream PRs from the commit message?

fetch.bs Outdated Show resolved Hide resolved
fetch.bs Outdated Show resolved Hide resolved
fetch.bs Outdated Show resolved Hide resolved
Rename the "extract-value flag" argument to the algorithm "collect an HTTP
quoted string" to a boolean "extract-value" that will by default be false.

Fixes: whatwg#1567
Downstream updates: whatwg/mimesniff#170
@dlrobertson
Copy link
Member Author

Thanks for tackling this. Just a couple nits. And maybe we should link the downstream PRs from the commit message?

Good point! Updated.

@annevk annevk merged commit b07a52c into whatwg:main May 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Rename "extract-value flag" to "extract-value" and define it as a boolean
2 participants