Add "only-if-cached" cache mode back #295
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM! |
| the response. | ||
|
|
||
| <dt>"<code title="">only-if-cached</code>" | ||
| <dd>Fetches uses any response in the HTTP cache matching the request, not paying attention to |
|
what about the privacy aspect (cache probing)? |
|
Cache probing would only be possible same-origin since this feature is restricted to same-origin. It might make it slightly easier if there was an XSS exploit to figure out capability URLs perhaps, but that still seems rather hard and with an XSS exploit you likely have access to sensitive information anyway. |
Fixes #159. The difference with the previous attempt is that it now has a “same-origin” mode restriction (enforced through the Fetch API).
|
LGTM |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #159. The difference with the previous attempt is that it now has
a “same-origin” mode restriction (enforced through the Fetch API).