Editorial: add note on event listeners & preflight #578
Conversation
|
I think that and using a |
OK, will add that. But where is the requirement defined about it happening when using a I can’t seem to find anything either in the Fetch spec or Streams spec that states it… |
Discussed on IRC at http://logs.glob.uno/?c=freenode%23whatwg&s=12%20Aug%202017&e=12%20Aug%202017#c1034349 |
fetch.bs
Outdated
| @@ -1003,6 +1003,11 @@ discouraged from using it for new features. It is rather unsafe. "<code>navigate | |||
| <dfn id=use-cors-preflight-flag export for=request>use-CORS-preflight flag</dfn>. Unless stated | |||
| otherwise, it is unset. | |||
|
|
|||
| <p class="note no-backref">The <a>use-CORS-preflight flag</a> being set is just one of several | |||
| conditions that can result in a <a>CORS-preflight request</a>. The <a>use-CORS-preflight flag</a> | |||
fetch.bs
Outdated
| @@ -1003,6 +1003,11 @@ discouraged from using it for new features. It is rather unsafe. "<code>navigate | |||
| <dfn id=use-cors-preflight-flag export for=request>use-CORS-preflight flag</dfn>. Unless stated | |||
| otherwise, it is unset. | |||
|
|
|||
| <p class="note no-backref">The <a>use-CORS-preflight flag</a> being set is just one of several | |||
| conditions that can result in a <a>CORS-preflight request</a>. The <a>use-CORS-preflight flag</a> | |||
| will be set if either one or more event listeners are registered on an {{XMLHttpRequestUpload}} | |||
fetch.bs
Outdated
| <p class="note no-backref">The <a>use-CORS-preflight flag</a> being set is just one of several | ||
| conditions that can result in a <a>CORS-preflight request</a>. The <a>use-CORS-preflight flag</a> | ||
| will be set if either one or more event listeners are registered on an {{XMLHttpRequestUpload}} | ||
| object, or else if a {{ReadableStream}} object is used for uploads. |
There was a problem hiding this comment.
s/, or else/or if/ (I think that looks better)
s/for uploads/in a request/
We already have this in the XHR spec, but I think it would be helpful to
readers to also have a note in the Fetch spec at point of use, because the
Fetch spec is what gets cited at StackOverflow and such as the source for
requirements on what causes a preflight. So omitting mention of this case from
the Fetch spec risks making people (continue to) forget this is among the
things that could be causing a preflight they’re running into but that they
don’t understand the reason for or how to prevent it.
Preview | Diff