Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Should converting chunk to a FileSystemWriteChunkType refer to IDL type conversion instead? #48

Closed
EdgarChen opened this issue Sep 2, 2022 · 1 comment · Fixed by #58
Closed

Should converting chunk to a FileSystemWriteChunkType refer to IDL type conversion instead? #48

EdgarChen opened this issue Sep 2, 2022 · 1 comment · Fixed by #58

Comments

@EdgarChen
Copy link
Member

See step 1 of https://fs.spec.whatwg.org/#write-a-chunk

Let input be the result of converting chunk to a FileSystemWriteChunkType. If this throws an exception, then return a promise rejected with that exception.

it refers to https://infra.spec.whatwg.org/#javascript-string-convert which seems wrong, should it refer to https://webidl.spec.whatwg.org/#dfn-convert-ecmascript-to-idl-value instead?
@EdgarChen EdgarChen changed the title Should converting chunk to a FileSystemWriteChunkType refer to https://webidl.spec.whatwg.org/#dfn-convert-ecmascript-to-idl-value instead? Should converting chunk to a FileSystemWriteChunkType refer to IDL type conversion instead? Sep 2, 2022
@a-sully
Copy link
Collaborator

a-sully commented Oct 1, 2022

Ah, I believe you're correct there. Would you mind putting up a PR?

EdgarChen added a commit to EdgarChen/fs that referenced this issue Oct 5, 2022
@EdgarChen
Fix IDL type conversion reference
6dcf8e6 
Fixes whatwg#48.
@EdgarChen EdgarChen mentioned this issue Oct 5, 2022
Merged
3 tasks
EdgarChen added a commit to EdgarChen/fs that referenced this issue Oct 5, 2022
@EdgarChen
Fix IDL type conversion reference
9638b58 
Fixes whatwg#48.
a-sully pushed a commit that referenced this issue Oct 5, 2022
@EdgarChen
Fix IDL type conversion reference (#58)
862d4aa 
Fixes #48.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix IDL type conversion reference EdgarChen/fs
2 participants
@EdgarChen @a-sully