Skip to content

Commit e5e96a9

Browse files
mounirlamouriannevk
authored andcommitted
Allow requestFullscreen() to be called from an orientation change event
Note that this flow of changes, requesting fullscreen from the orientation change event, can result in a "bad frame", an inbetween state that's not necessarily desired. Implementers found this acceptable. Fixes #34.
1 parent 9592913 commit e5e96a9

File tree

2 files changed

+25
-7
lines changed

2 files changed

+25
-7
lines changed

Overview.html

Lines changed: 13 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@
99

1010
<hgroup>
1111
<h1 class="p-name">Fullscreen API</h1>
12-
<h2 class="no-num no-toc">Living Standard — Last Updated 20 July 2016</h2>
12+
<h2 class="no-num no-toc">Living Standard — Last Updated 21 July 2016</h2>
1313
</hgroup>
1414

1515
<dl>
@@ -195,6 +195,15 @@ <h2 id="model"><span class="secno">3 </span>Model</h2>
195195

196196
<p><dfn id="fullscreen-is-supported">Fullscreen is supported</dfn> if there is no previously-established user
197197
preference, security risk, or platform limitation.
198+
199+
<p>An algorithm is <dfn id="allowed-to-request-fullscreen">allowed to request fullscreen</dfn> if one of the following is true:
200+
201+
<ul>
202+
<li><p>The algorithm is <a class="external" data-anolis-spec="html" href="https://html.spec.whatwg.org/multipage/interaction.html#triggered-by-user-activation">triggered by user activation</a>.
203+
204+
<li><p>The algorithm is
205+
<a class="external" data-anolis-spec="screen-orientation" href="https://w3c.github.io/screen-orientation/#dfn-triggered-by-a-user-generated-orientation-change">triggered by a user generated orientation change</a>.
206+
</ul>
198207
<!-- cross-process -->
199208

200209

@@ -281,10 +290,9 @@ <h2 id="api"><span class="secno">4 </span>API</h2>
281290
<li><p>The <a href="#fullscreen-element-ready-check">fullscreen element ready check</a> for <var title="">pending</var>
282291
returns false.
283292

284-
<li><p>This algorithm is not
285-
<a class="external" data-anolis-spec="html" href="https://html.spec.whatwg.org/multipage/browsers.html#allowed-to-show-a-popup">allowed to show a popup</a>.
286-
287293
<li><p><a href="#fullscreen-is-supported" title="Fullscreen is supported">Fullscreen is <em>not</em> supported</a>.
294+
295+
<li><p>This algorithm is not <a href="#allowed-to-request-fullscreen">allowed to request fullscreen</a>.
288296
</ul>
289297

290298
<li><p>Return <var>promise</var>, and run the remaining steps
@@ -750,6 +758,7 @@ <h2 class="no-num" id="acknowledgments">Acknowledgments</h2>
750758
Josh Soref,
751759
Matt Falkenhagen,
752760
Mihai Balan,
761+
Mounir Lamouri,
753762
Øyvind Stenhaug,
754763
Pat Ladd,
755764
Philip Jägenstedt,

Overview.src.html

Lines changed: 12 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -180,6 +180,15 @@ <h2>Model</h2>
180180

181181
<p><dfn>Fullscreen is supported</dfn> if there is no previously-established user
182182
preference, security risk, or platform limitation.
183+
184+
<p>An algorithm is <dfn>allowed to request fullscreen</dfn> if one of the following is true:
185+
186+
<ul>
187+
<li><p>The algorithm is <span data-anolis-spec=html>triggered by user activation</span>.
188+
189+
<li><p>The algorithm is
190+
<span data-anolis-spec=screen-orientation>triggered by a user generated orientation change</span>.
191+
</ul>
183192
<!-- cross-process -->
184193

185194

@@ -266,10 +275,9 @@ <h2>API</h2>
266275
<li><p>The <span>fullscreen element ready check</span> for <var title>pending</var>
267276
returns false.
268277

269-
<li><p>This algorithm is not
270-
<span data-anolis-spec=html>allowed to show a popup</span>.
271-
272278
<li><p><span title="Fullscreen is supported">Fullscreen is <em>not</em> supported</span>.
279+
280+
<li><p>This algorithm is not <span>allowed to request fullscreen</span>.
273281
</ul>
274282

275283
<li><p>Return <var>promise</var>, and run the remaining steps
@@ -714,6 +722,7 @@ <h2 class=no-num>Acknowledgments</h2>
714722
Josh Soref,
715723
Matt Falkenhagen,
716724
Mihai Balan,
725+
Mounir Lamouri,
717726
Øyvind Stenhaug,
718727
Pat Ladd,
719728
Philip Jägenstedt,

0 commit comments

Comments
 (0)