-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
.pre-process-main.pl can be simplified or rolled into Wattsi #234
Comments
👍 yeah, all looks doable — and getting rid of the Perl dependency would be a nice win |
One thing I realized is that, unless this is done in a failure-tolerant way (which seems subpar), then this would probably break wattsi-server and thus PR preview :-/. |
domenic
added a commit
that referenced
this issue
Sep 21, 2020
sideshowbarker
pushed a commit
that referenced
this issue
Sep 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I'm idly investigating if we can simplify html-build by removing the Perl scripts. Here's at least one piece of low-hanging fruit.
If you run
and diff the results, there are only three transformations actually performed:
<!--REPRESENTS article-->
and friends in https://html.spec.whatwg.org/#usage-summary-2 with the values defined elsewhere in the document<!--BOILERPLATE cldr.inc -->
and friends with some files from the build process<pre>EXAMPLE offline/clock/clock.appcache</pre>
and friends with their contents from thedemos/
folder.All the stuff in
parserExpander
and its sub-functionexpand
appear to be unused.I think we should add a facility to Wattsi to do arbitrary file insertions, e.g.
<!--INSERTFILE filename-->
. Then we can eliminate the<!--BOILERPLATE x-->
and<pre>EXAMPLE x</pre>
specializations of this from the Perl script and leave it doing only the more complicated<!--REPRESENTS -->
business.The REPRESENTS thing is part of a more general class of problems (basically, substituting text or HTML from one part of the spec into another) that we could try to tackle in Wattsi as a separate effort, after we've done the easier stuff.
The text was updated successfully, but these errors were encountered: