Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.cache folder is not created by build.sh #260

Closed
surma opened this issue Feb 5, 2021 · 1 comment · Fixed by #261
Closed

.cache folder is not created by build.sh #260

surma opened this issue Feb 5, 2021 · 1 comment · Fixed by #261

Comments

@surma
Copy link
Contributor

surma commented Feb 5, 2021

I have a fresh clone and I am follwing the instructions. Running ./build.sh --docker fails with:

docker: Error response from daemon: invalid mount config for type "bind": bind source path does not exist:
/Users/surma/src/github.com/whatwg/html-build/.cache.

Creating .cache manually fixes the problem. Might be nice if the script did that for me.

@domenic
Copy link
Member

domenic commented Feb 8, 2021

Fascinating. This must be a Windows vs. Mac docker difference? I deleted my .cache folder and ran that exact command and it was created with no problem.

Would you be able to work on a pull request for this, since I can't really test it myself? I think moving clearCacheIfNecessary up to before the if [[ $USE_DOCKER == "true" ]] line would work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging a pull request may close this issue.

2 participants