Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

navigable's "is delaying load events" is not reset when navigation aborted #10252

Open
kalenikaliaksandr opened this issue Apr 5, 2024 · 0 comments
Open

navigable's "is delaying load events" is not reset when navigation aborted #10252

kalenikaliaksandr opened this issue Apr 5, 2024 · 0 comments
Labels
topic: navigation

Comments

@kalenikaliaksandr
Copy link
Member

What is the issue with the HTML Standard?

Steps to reproduce:

  1. navigate (step 12) sets navigable's is delaying load events to true.
  2. navigate (step 20.2) aborts subsequent steps and finalize a cross-document navigation that is supposed to reset is delaying load events never reached.
kalenikaliaksandr added a commit to kalenikaliaksandr/serenity that referenced this issue Apr 5, 2024
@kalenikaliaksandr
LibWeb: Add missing set_delaying_load_events(false) in navigate()
17aeb60 
If navigation early returns before reaching "finalize a cross document
navigation" then we have to make sure delaying load events is disabled.

See spec issue whatwg/html#10252
awesomekling pushed a commit to SerenityOS/serenity that referenced this issue Apr 5, 2024
@kalenikaliaksandr @awesomekling
LibWeb: Add missing set_delaying_load_events(false) in navigate()
aefed21 
If navigation early returns before reaching "finalize a cross document
navigation" then we have to make sure delaying load events is disabled.

See spec issue whatwg/html#10252
alimpfard pushed a commit to alimpfard/serenity that referenced this issue Apr 22, 2024
@kalenikaliaksandr @alimpfard
LibWeb: Add missing set_delaying_load_events(false) in navigate()
0ce4081 
If navigation early returns before reaching "finalize a cross document
navigation" then we have to make sure delaying load events is disabled.

See spec issue whatwg/html#10252
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
topic: navigation
Milestone
No milestone
Development

No branches or pull requests
1 participant
@kalenikaliaksandr