Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Output caniuse boxes in the dev edition as well #2794

Closed
domenic opened this issue Jun 28, 2017 · 0 comments · Fixed by #2816
Closed

Output caniuse boxes in the dev edition as well #2794

domenic opened this issue Jun 28, 2017 · 0 comments · Fixed by #2816

Comments

@domenic
Copy link
Member

domenic commented Jun 28, 2017

They're arguably more useful for developers than for browser implementers, so they should definitely be there. I think our build tools are probably omitting them currently.

(And don't forget to style them.)

domenic added a commit to whatwg/wattsi that referenced this issue Jul 5, 2017
domenic added a commit that referenced this issue Jul 5, 2017
domenic added a commit to whatwg/wattsi that referenced this issue Jul 13, 2017
In the developer's edition, previously if a subdfn was not ever
referenced, it would not get an ID. This meant it could not be linked to
from other pages on the web, which is bad, and also interfered with
trying to make the caniuse annotation code work, for whatwg/html#2794.
This change ensures that all subdfns get IDs.
domenic added a commit that referenced this issue Jul 14, 2017
Fixes #2794. Most of the work is done in
whatwg/wattsi#54; this commit consists of:

* Incorporating the styles for the caniuse boxes into the dev edition,
  with some tweaks.
* Marking up, or in some cases adding, appropriate subdfns for topics
  that appear on caniuse but are missing in the dev edition.

Fyrd/caniuse#3593 will also be important to get
two caniuse boxes to show up properly.
Fyrd pushed a commit to Fyrd/caniuse that referenced this issue Jul 14, 2017
These IDs also appear in the developer's edition of HTML (https://html.spec.whatwg.org/dev), and so including these allows caniuse integration with the dev edition (whatwg/html#2794).
domenic added a commit that referenced this issue Jul 20, 2017
Fixes #2794. Most of the work is done in
whatwg/wattsi#54; this commit consists of:

* Incorporating the styles for the caniuse boxes into the dev edition,
  with some tweaks.
* Marking up, or in some cases adding, appropriate subdfns for topics
  that appear on caniuse but are missing in the dev edition.

Fyrd/caniuse#3593 will also be important to get
two caniuse boxes to show up properly.
sideshowbarker pushed a commit to whatwg/wattsi that referenced this issue Jul 20, 2017
Helps with whatwg/html#2794.

Also adds IDs for unreferenced subdfns.
In the developer's edition, previously if a subdfn was not ever
referenced, it would not get an ID. This meant it could not be linked to
from other pages on the web, which is bad, and also interfered with
trying to make the caniuse annotation code work, for whatwg/html#2794.
This change also ensures that all subdfns get IDs.
annevk pushed a commit that referenced this issue Aug 19, 2017
Fixes #2794. Most of the work is done in
whatwg/wattsi#54; this commit consists of:

* Incorporating the styles for the caniuse boxes into the dev edition,
  with some tweaks.
* Marking up, or in some cases adding, appropriate subdfns for topics
  that appear on caniuse but are missing in the dev edition.

Fyrd/caniuse#3593 will also be important to get
two caniuse boxes to show up properly.
alice pushed a commit to alice/html that referenced this issue Jan 8, 2019
Fixes whatwg#2794. Most of the work is done in
whatwg/wattsi#54; this commit consists of:

* Incorporating the styles for the caniuse boxes into the dev edition,
  with some tweaks.
* Marking up, or in some cases adding, appropriate subdfns for topics
  that appear on caniuse but are missing in the dev edition.

Fyrd/caniuse#3593 will also be important to get
two caniuse boxes to show up properly.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging a pull request may close this issue.

1 participant